fix: surrogateKeys not being added when using CoreCache (#1219)

pablodelolmo · web-flow · commit b0efe20c2f6f · 2025-11-07T09:37:30.000-08:00
diff --git a/runtime/fastly/builtins/cache-core.cpp b/runtime/fastly/builtins/cache-core.cpp
@@ -242,7 +242,7 @@ JS::Result<host_api::CacheWriteOptions> parseTransactionUpdateOptions(JSContext
   }
   if (!surrogateKeys_val.isUndefined()) {
     JS::ForOfIterator it(cx);
-    if (!it.init(vary_val)) {
+    if (!it.init(surrogateKeys_val)) {
       return JS::Result<host_api::CacheWriteOptions>(JS::Error());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ JS::Result<host_api::CacheWriteOptions> parseTransactionUpdateOptions(JSContext`
`242`	`242`	`}`
`243`	`243`	`if (!surrogateKeys_val.isUndefined()) {`
`244`	`244`	`JS::ForOfIterator it(cx);`
`245`		`- if (!it.init(vary_val)) {`
	`245`	`+ if (!it.init(surrogateKeys_val)) {`
`246`	`246`	`return JS::Result<host_api::CacheWriteOptions>(JS::Error());`
`247`	`247`	`}`
`248`	`248`