Support sqlmodel_rebuild
#1314
Closed
Support sqlmodel_rebuild
#1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@sqlmodel` decorator introduced by `fquery.sqlmodel` moves schema
definitions and types closer to the object model (references) instead of
foreign_keys.
Instead of writing:
```
class Hero(SQLModel, table=True):
...
team_id: int | None = Field(default=None, foreign_key="team.id")
```
you could write:
```
@sqlmodel
class Hero:
...
team: Team | None = foreign_key("team.id")
```
Everything works the same as before. Only the syntax has changed.
However, if `Team` also has a foreign key to `Hero`, then one of them
will have to use forward declaration so type checkers work.
In those cases we need a two pass solution where in the second pass,
with the full type definition available, we can generate the correct
code.
Refactor some of the existing code to introduce `sqlmodel_rebuild()`.
|
This was a test to see #1270 had merge errors. Looks like these are real test failures. Looking into them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@sqlmodeldecorator introduced byfquery.sqlmodelmoves schema definitions and types closer to the object model (references) instead of foreign_keys.Instead of writing:
you could write:
Everything works the same as before. Only the syntax has changed. However, if
Teamalso has a foreign key toHero, then one of them will have to use forward declaration so type checkers work.In those cases we need a two pass solution where in the second pass, with the full type definition available, we can generate the correct code.
Refactor some of the existing code to introduce
sqlmodel_rebuild().