Skip to content

Remove the NoReturn return type #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2023
Merged

Remove the NoReturn return type #232

merged 1 commit into from
Oct 22, 2023

Conversation

wu-clan
Copy link
Member

@wu-clan wu-clan commented Oct 22, 2023

PLR.

@wu-clan wu-clan requested a review from downdawn October 22, 2023 00:29
@downdawn
Copy link
Collaborator

Why? Is there anything bad about it?

@wu-clan
Copy link
Member Author

wu-clan commented Oct 22, 2023

NoReturn should be used in infinite loop functions or system API functions, for regular returns, returning None is more friendly

@wu-clan
Copy link
Member Author

wu-clan commented Oct 22, 2023

Look here: python/typing#165

@wu-clan wu-clan merged commit d0b16b6 into fastapi-practices:master Oct 22, 2023
@wu-clan wu-clan deleted the delete-NoReturn-typing branch October 22, 2023 12:46
@downdawn
Copy link
Collaborator

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@downdawn downdawn downdawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wu-clan @downdawn