Skip to content

More Point Sampling Methods from meshes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hansen7 opened this issue Feb 10, 2020 · 4 comments
Closed

More Point Sampling Methods from meshes #39

hansen7 opened this issue Feb 10, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@hansen7
Copy link

hansen7 commented Feb 10, 2020

🚀 Feature

More Point Sampling Methods from meshes

Motivation

It would be great if I could have more options on how to get the set of surface point with different point samplings, such as

Pitch

More sampling options will enable us to have better understanding on how our model will perform under different situations :)

If you think its necessary, I can submit a P.R

@nikhilaravi nikhilaravi added the enhancement New feature or request label Feb 10, 2020
@nikhilaravi
Copy link
Contributor

@hansen7 thanks for the suggestion! :)

Could share some more details about your proposed implementation for either of the two methods you mentioned above?

Please be aware that for new features to PyTorch3D we require:

  1. CPU and GPU implementations
  2. Comprehensive unit tests and benchmark tests (following the format in the tests folder)
  3. All style checks and unit tests must pass
  4. Any changes to the public API to be discussed first in this issue (i.e please follow the API format from the current sample_points_from_meshes function)

As a first step you can also submit a PR with the PyTorch implementation of one of the methods which we can review. Let us know if you have any questions.

@williamljb
Copy link

Hi Nikhila Ravi,

If it is not too complicated, it would be great if the current sampling algorithm can have an option to smooth the normals sampled.

Thank you for the great work!

@nikhilaravi
Copy link
Contributor

nikhilaravi commented Sep 16, 2021

@williamljb FYI farthest point sampling is now available in pytorch3d in the main branch on GitHub (not yet in a release):

from pytorch3d.ops import sample_farthest_points

@williamljb
Copy link

@williamljb FYI farthest point sampling is now available in pytorch3d in the main branch on GitHub (not yet in a release):

from pytorch3d.ops import sample_farthest_points

Great! Thanks!

@hansen7 hansen7 closed this as completed Sep 20, 2021
facebook-github-bot pushed a commit that referenced this issue Jul 19, 2022
Summary:
X-link: fairinternal/pytorch3d#39

Blender and LLFF cameras were sending screen space focal length and principal point to a camera init function expecting NDC

Reviewed By: shapovalov

Differential Revision: D37788686

fbshipit-source-id: 2ddf7436248bc0d174eceb04c288b93858138582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants