-
Notifications
You must be signed in to change notification settings - Fork 48.7k
build: add exports field for useSES #24557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Comparing: 4c03bb6...bc314f6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
shim wildcard with extension fix shim/with-selector path
5345109
to
bc314f6
Compare
Hi react folks, any idea which subpath exports is missing that lead to this error in test? Wanna get some hints to fix them |
There's an existing PR in #24440 so we should probably merge that one. But the author says it's a breaking change. Why is it? |
Thanks for referencing the existing one! I'm not sure the reason why is that. Maybe the file path changing will breaks code that are directly importing it? |
Summary
Add
exports
field to use-sync-external-store for usage in esm modules (.mjs).How did you test this change?
We added useESE in swr for react 18 support, and trying to test it with next.js, I got the above error when running
next build
. The reason seems because ofexports
field is missing in useESE that break the subpath imports