Cancelling Travis build on commits with docs updates only. #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently recognized patterns: * any Markdown files (*.md) * any files in docs or examples directories. Closes facebook#1768.
| if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then | ||
| TRAVIS_COMMIT_RANGE="FETCH_HEAD...$TRAVIS_BRANCH" | ||
| fi | ||
| git diff --name-only $TRAVIS_COMMIT_RANGE | grep -qvE '(\.md$)|(^(docs|examples))/' || { |
There was a problem hiding this comment.
Is this going to match and bail if a documentation change is in the same PR/commit as a change to code?
There was a problem hiding this comment.
What it basically says is "if there're no other changed files but docs/examples, immediately exit".
There was a problem hiding this comment.
@zpao Does this answer your question?
zpao
added a commit
that referenced
this pull request
Aug 8, 2014
Cancelling Travis build on commits with docs updates only.
|
@zpao I assume this was "yes" :) |
|
It was :) |
|
@zpao Nice, seems to work: https://travis-ci.org/facebook/react/jobs/32250596 |
RReverser
added a commit
to RReverser/react
that referenced
this pull request
Sep 5, 2014
…ged. See facebook#1768 / facebook#2000 for original issue. See travis-ci/travis-ci#1719 (comment) for origin of this solution.
RReverser
added a commit
to RReverser/react
that referenced
this pull request
Sep 5, 2014
See facebook#1768 / facebook#2000 for original issue. See travis-ci/travis-ci#1719 (comment) for problem description and origin of this fix. This is still a temporary fix until travis-ci/travis-core#383 is merged.
hdhoang
added a commit
to hdhoang/anne-key
that referenced
this pull request
Mar 1, 2018
Adapted from facebook/react#2000. Close #2.
hdhoang
added a commit
to hdhoang/anne-key
that referenced
this pull request
Mar 1, 2018
Adapted from facebook/react#2000. Close #2.
7 tasks
blackholegalaxy
added a commit
to blackholegalaxy/gitlab-registry-pruner-docker
that referenced
this pull request
Apr 15, 2018
ntwb
pushed a commit
to WordPress/gutenberg
that referenced
this pull request
Aug 9, 2018
…8728) This comes from [a discussion](https://wordpress.slack.com/archives/C02QB2JS7/p1533720310000209) with @gziolo in #core-editor. Basically we can skip the full Travis build if the commit range being tested only contains changes to `.md` files. Modeled after: facebook/react#2000 In my testing, this shortens the Travis run time on each item in the test list from ~4-6 minutes down to ~1 minute or less for docs only changes. Should help speed up merging non-code PRs. Here are some test builds I did from my fork: [Only change .md file](https://travis-ci.org/earnjam/gutenberg/builds/413732648) - aborts early [Only change .js file](https://travis-ci.org/earnjam/gutenberg/builds/413733458) - runs normally [Changes both .md and .js files](https://travis-ci.org/earnjam/gutenberg/builds/413733882) - runs normally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently recognized patterns:
Closes #1768.