Add DEV warning if forwardRef function doesn't use the ref param #13168
+34
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
Jul 7, 2018
Merged
This was referenced Sep 7, 2018
ghost
mentioned this pull request
This was referenced Nov 1, 2018
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
…168) * Add DEV warning if forwardRef function doesn't use the ref param * Fixed a forwardRef arity warning in another test
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a few places where the
forwardRefAPI was misunderstood and misused. Maybe this warning can help catch them?I didn't differentiate between an arity of zero or one. Seemed better to keep the warning simple.
I could add a link to the
forwardRefAPI docs if we think it would be helpful? Although none of the other warnings do this.