[forgive] Init (#31918)

poteto · web-flow · commit d42a90cf4f8a · 2025-02-25T12:19:11.000-05:00
Init basic LSP. At the moment the extension doesn't do anything
interesting, but it does compile successfully.
diff --git a/.gitignore b/.gitignore
@@ -37,3 +37,4 @@ packages/react-devtools-fusebox/dist
 packages/react-devtools-inline/dist
 packages/react-devtools-shell/dist
 packages/react-devtools-timeline/dist
+
diff --git a/compiler/.gitignore b/compiler/.gitignore
@@ -21,4 +21,8 @@ dist
 .spr.yml
 testfilter.txt
 
-bundle-oss.sh
+bundle-oss.sh
+
+# forgive
+*.vsix
+.vscode-test
diff --git a/compiler/packages/react-forgive/.vscode-test.mjs b/compiler/packages/react-forgive/.vscode-test.mjs
@@ -0,0 +1,3 @@
+import {defineConfig} from '@vscode/test-cli';
+
+export default defineConfig({files: 'dist/test/**/*.test.js'});
diff --git a/compiler/packages/react-forgive/.yarnrc b/compiler/packages/react-forgive/.yarnrc
@@ -0,0 +1 @@
+ignore-engines true
diff --git a/compiler/packages/react-forgive/LICENSE b/compiler/packages/react-forgive/LICENSE
@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) Meta Platforms, Inc. and affiliates.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
diff --git a/compiler/packages/react-forgive/client/package.json b/compiler/packages/react-forgive/client/package.json
@@ -11,7 +11,7 @@
   "repository": {
     "type": "git",
     "url": "git+https://github.com/facebook/react.git",
-    "directory": "compiler/packages/react-forgive-client"
+    "directory": "compiler/packages/react-forgive"
   },
   "dependencies": {
     "vscode-languageclient": "^9.0.1"
diff --git a/compiler/packages/react-forgive/client/src/extension.ts b/compiler/packages/react-forgive/client/src/extension.ts
@@ -0,0 +1,60 @@
+import * as path from 'path';
+import {ExtensionContext, window as Window} from 'vscode';
+
+import {
+  LanguageClient,
+  LanguageClientOptions,
+  ServerOptions,
+  TransportKind,
+} from 'vscode-languageclient/node';
+
+let client: LanguageClient;
+
+export function activate(context: ExtensionContext) {
+  const serverModule = context.asAbsolutePath(path.join('dist', 'server.js'));
+
+  // If the extension is launched in debug mode then the debug server options are used
+  // Otherwise the run options are used
+  const serverOptions: ServerOptions = {
+    run: {
+      module: serverModule,
+      transport: TransportKind.ipc,
+    },
+    debug: {
+      module: serverModule,
+      transport: TransportKind.ipc,
+    },
+  };
+
+  const clientOptions: LanguageClientOptions = {
+    documentSelector: [
+      {scheme: 'file', language: 'javascriptreact'},
+      {scheme: 'file', language: 'typescriptreact'},
+    ],
+    progressOnInitialization: true,
+  };
+
+  // Create the language client and start the client.
+  try {
+    client = new LanguageClient(
+      'react-forgive',
+      'React Analyzer',
+      serverOptions,
+      clientOptions,
+    );
+  } catch {
+    Window.showErrorMessage(
+      `React Analyzer couldn't be started. See the output channel for details.`,
+    );
+    return;
+  }
+
+  client.registerProposedFeatures();
+  client.start();
+}
+
+export function deactivate(): Thenable<void> | undefined {
+  if (client !== undefined) {
+    return client.stop();
+  }
+}
diff --git a/compiler/packages/react-forgive/package.json b/compiler/packages/react-forgive/package.json
@@ -19,7 +19,7 @@
   ],
   "publisher": "Meta",
   "engines": {
-    "vscode": "^1.75.0"
+    "vscode": "^1.96.0"
   },
   "activationEvents": [
     "onLanguage:javascriptreact",
@@ -43,14 +43,19 @@
     "package": "rm -f react-forgive-0.0.0.vsix && vsce package --yarn",
     "postinstall": "cd client && yarn install && cd ../server && yarn install && cd ..",
     "pretest": "yarn run compile && yarn run lint",
-    "test": "echo 'no tests'",
+    "test": "vscode-test",
     "vscode:prepublish": "yarn run compile",
     "watch": "scripts/build.mjs --watch"
   },
   "devDependencies": {
     "@eslint/js": "^9.13.0",
+    "@types/mocha": "^10.0.10",
     "@types/node": "^20",
+    "@types/vscode": "^1.96.0",
+    "@vscode/test-cli": "^0.0.10",
+    "@vscode/test-electron": "^2.4.1",
     "eslint": "^9.13.0",
+    "mocha": "^11.0.1",
     "typescript-eslint": "^8.16.0",
     "yargs": "^17.7.2"
   }
diff --git a/compiler/packages/react-forgive/scripts/server.mjs b/compiler/packages/react-forgive/scripts/server.mjs
@@ -12,7 +12,7 @@ const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
 
 export const entryPoint = path.join(__dirname, '../server/src/index.ts');
-export const outfile = path.join(__dirname, '../dist/extension.js');
+export const outfile = path.join(__dirname, '../dist/server.js');
 export const config = {
   entryPoints: [entryPoint],
   outfile,
diff --git a/compiler/packages/react-forgive/server/package.json b/compiler/packages/react-forgive/server/package.json
@@ -5,15 +5,21 @@
   "description": "Experimental LSP server",
   "license": "MIT",
   "scripts": {
-    "build": "echo 'no build'",
+    "build": "rimraf dist && rollup --config --bundleConfigAsCjs",
     "test": "echo 'no tests'"
   },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/facebook/react.git",
-    "directory": "compiler/packages/react-forgive-server"
+    "directory": "compiler/packages/react-forgive"
   },
   "dependencies": {
+    "@babel/core": "^7.26.0",
+    "@babel/parser": "^7.26.0",
+    "@babel/plugin-syntax-typescript": "^7.25.9",
+    "@babel/types": "^7.26.0",
+    "cosmiconfig": "^9.0.0",
+    "prettier": "^3.3.3",
     "vscode-languageserver": "^9.0.1",
     "vscode-languageserver-textdocument": "^1.0.12"
   }
diff --git a/compiler/packages/react-forgive/server/src/compiler/index.ts b/compiler/packages/react-forgive/server/src/compiler/index.ts
@@ -0,0 +1,58 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import type * as BabelCore from '@babel/core';
+import {parseAsync, transformFromAstAsync} from '@babel/core';
+import BabelPluginReactCompiler, {
+  type PluginOptions,
+} from 'babel-plugin-react-compiler/src';
+import * as babelParser from 'prettier/plugins/babel.js';
+import * as estreeParser from 'prettier/plugins/estree';
+import * as typescriptParser from 'prettier/plugins/typescript';
+import * as prettier from 'prettier/standalone';
+
+type CompileOptions = {
+  text: string;
+  file: string;
+  options: PluginOptions | null;
+};
+export async function compile({
+  text,
+  file,
+  options,
+}: CompileOptions): Promise<BabelCore.BabelFileResult> {
+  const ast = await parseAsync(text, {
+    sourceFileName: file,
+    parserOpts: {
+      plugins: ['typescript', 'jsx'],
+    },
+    sourceType: 'module',
+  });
+  const plugins =
+    options != null
+      ? [[BabelPluginReactCompiler, options]]
+      : [[BabelPluginReactCompiler]];
+  const result = await transformFromAstAsync(ast, text, {
+    filename: file,
+    highlightCode: false,
+    retainLines: true,
+    plugins,
+    sourceType: 'module',
+    sourceFileName: file,
+  });
+  if (result?.code == null) {
+    throw new Error(
+      `Expected BabelPluginReactCompiler to compile successfully, got ${result}`,
+    );
+  }
+  result.code = await prettier.format(result.code, {
+    semi: false,
+    parser: 'babel-ts',
+    plugins: [babelParser, estreeParser, typescriptParser],
+  });
+  return result;
+}
diff --git a/compiler/packages/react-forgive/server/src/compiler/options.ts b/compiler/packages/react-forgive/server/src/compiler/options.ts
@@ -0,0 +1,25 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import {
+  parsePluginOptions,
+  type PluginOptions,
+} from 'babel-plugin-react-compiler/src';
+import {cosmiconfigSync} from 'cosmiconfig';
+
+export function resolveReactConfig(projectPath: string): PluginOptions | null {
+  const explorerSync = cosmiconfigSync('react', {
+    searchStrategy: 'project',
+    cache: true,
+  });
+  const result = explorerSync.search(projectPath);
+  if (result != null) {
+    return parsePluginOptions(result.config);
+  } else {
+    return null;
+  }
+}
diff --git a/compiler/packages/react-forgive/server/src/index.ts b/compiler/packages/react-forgive/server/src/index.ts
@@ -4,3 +4,90 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
+
+import {TextDocument} from 'vscode-languageserver-textdocument';
+import {
+  createConnection,
+  type InitializeParams,
+  type InitializeResult,
+  ProposedFeatures,
+  TextDocuments,
+  TextDocumentSyncKind,
+} from 'vscode-languageserver/node';
+import {compile} from './compiler';
+import {type PluginOptions} from 'babel-plugin-react-compiler/src';
+import {resolveReactConfig} from './compiler/options';
+import {type BabelFileResult} from '@babel/core';
+
+const SUPPORTED_LANGUAGE_IDS = new Set([
+  'javascript',
+  'javascriptreact',
+  'typescript',
+  'typescriptreact',
+]);
+
+const connection = createConnection(ProposedFeatures.all);
+const documents = new TextDocuments(TextDocument);
+
+let compilerOptions: PluginOptions | null = null;
+let lastResult: BabelFileResult | null = null;
+
+connection.onInitialize((_params: InitializeParams) => {
+  // TODO(@poteto) get config fr
+  compilerOptions = resolveReactConfig('.');
+  const result: InitializeResult = {
+    capabilities: {
+      textDocumentSync: TextDocumentSyncKind.Full,
+      codeLensProvider: {resolveProvider: true},
+    },
+  };
+  return result;
+});
+
+connection.onInitialized(() => {
+  connection.console.log('initialized');
+});
+
+documents.onDidOpen(async event => {
+  if (SUPPORTED_LANGUAGE_IDS.has(event.document.languageId)) {
+    const text = event.document.getText();
+    const result = await compile({
+      text,
+      file: event.document.uri,
+      options: compilerOptions,
+    });
+    if (result.code != null) {
+      lastResult = result;
+    }
+  }
+});
+
+documents.onDidChangeContent(async event => {
+  if (SUPPORTED_LANGUAGE_IDS.has(event.document.languageId)) {
+    const text = event.document.getText();
+    const result = await compile({
+      text,
+      file: event.document.uri,
+      options: compilerOptions,
+    });
+    if (result.code != null) {
+      lastResult = result;
+    }
+  }
+});
+
+connection.onDidChangeWatchedFiles(change => {
+  connection.console.log(
+    change.changes.map(c => `File changed: ${c.uri}`).join('\n'),
+  );
+});
+
+connection.onCodeLens(params => {
+  connection.console.log('lastResult: ' + JSON.stringify(lastResult, null, 2));
+  connection.console.log('params: ' + JSON.stringify(params, null, 2));
+  return [];
+});
+
+documents.listen(connection);
+connection.listen();
+connection.console.info(`React Analyzer running in node ${process.version}`);
diff --git a/compiler/packages/react-forgive/server/tsconfig.json b/compiler/packages/react-forgive/server/tsconfig.json
@@ -1,13 +1,15 @@
 {
   "extends": "@tsconfig/strictest/tsconfig.json",
   "compilerOptions": {
-    "module": "CommonJS",
-    "moduleResolution": "node",
-    "outDir": "dist",
+    "module": "ES2015",
+    "moduleResolution": "Bundler",
+    "rootDir": "../../..",
+    "noEmit": true,
     "jsx": "react-jsxdev",
-    "lib": ["ES2020"],
-    "target": "ES2020",
+    "target": "ES2015",
+    "sourceMap": false,
+    "removeComments": true,
   },
   "exclude": ["node_modules", ".vscode-test"],
-  "include": ["src/**/*.ts"],
+  "include": ["src/**/*.ts"]
 }
diff --git a/compiler/packages/react-forgive/server/yarn.lock b/compiler/packages/react-forgive/server/yarn.lock
diff --git a/compiler/yarn.lock b/compiler/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import {defineConfig} from '@vscode/test-cli';`
	`2`	`+`
	`3`	`+export default defineConfig({files: 'dist/test/*/.test.js'});`