Skip to content

Commit 578853e

Browse files
author
Brian Vaughn
committed
Wrap StyleX features behind new enableStyleXFeatures flag
Only enabled for FB builds (for now)
1 parent c48a710 commit 578853e

File tree

6 files changed

+28
-18
lines changed

6 files changed

+28
-18
lines changed

packages/react-devtools-shared/src/backend/renderer.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,10 @@ import {
8282
MEMO_SYMBOL_STRING,
8383
} from './ReactSymbols';
8484
import {format} from './utils';
85-
import {enableProfilerChangedHookIndices} from 'react-devtools-feature-flags';
85+
import {
86+
enableProfilerChangedHookIndices,
87+
enableStyleXFeatures,
88+
} from 'react-devtools-feature-flags';
8689
import is from 'shared/objectIs';
8790
import isArray from 'shared/isArray';
8891
import hasOwnProperty from 'shared/hasOwnProperty';
@@ -3238,8 +3241,10 @@ export function attach(
32383241
const modifiedProps = {
32393242
...memoizedProps,
32403243
};
3241-
if (modifiedProps.hasOwnProperty('xstyle')) {
3242-
modifiedProps.xstyle = getStyleXValues(modifiedProps.xstyle);
3244+
if (enableStyleXFeatures) {
3245+
if (modifiedProps.hasOwnProperty('xstyle')) {
3246+
modifiedProps.xstyle = getStyleXValues(modifiedProps.xstyle);
3247+
}
32433248
}
32443249

32453250
return {

packages/react-devtools-shared/src/config/DevToolsFeatureFlags.core-fb.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
* It should always be imported from "react-devtools-feature-flags".
1414
************************************************************************/
1515

16+
export const consoleManagedByDevToolsDuringStrictMode = false;
17+
export const enableLogger = true;
18+
export const enableNamedHooksFeature = true;
1619
export const enableProfilerChangedHookIndices = true;
20+
export const enableStyleXFeatures = true;
1721
export const isInternalFacebookBuild = true;
18-
export const enableNamedHooksFeature = true;
19-
export const enableLogger = true;
20-
export const consoleManagedByDevToolsDuringStrictMode = false;
2122

2223
/************************************************************************
2324
* Do not edit the code below.

packages/react-devtools-shared/src/config/DevToolsFeatureFlags.core-oss.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
* It should always be imported from "react-devtools-feature-flags".
1414
************************************************************************/
1515

16+
export const consoleManagedByDevToolsDuringStrictMode = false;
17+
export const enableLogger = false;
18+
export const enableNamedHooksFeature = true;
1619
export const enableProfilerChangedHookIndices = true;
20+
export const enableStyleXFeatures = false;
1721
export const isInternalFacebookBuild = false;
18-
export const enableNamedHooksFeature = true;
19-
export const enableLogger = false;
20-
export const consoleManagedByDevToolsDuringStrictMode = false;
2122

2223
/************************************************************************
2324
* Do not edit the code below.

packages/react-devtools-shared/src/config/DevToolsFeatureFlags.default.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@
1313
* It should always be imported from "react-devtools-feature-flags".
1414
************************************************************************/
1515

16+
export const consoleManagedByDevToolsDuringStrictMode = true;
17+
export const enableLogger = false;
18+
export const enableNamedHooksFeature = true;
1619
export const enableProfilerChangedHookIndices = true;
20+
export const enableStyleXFeatures = false;
1721
export const isInternalFacebookBuild = false;
18-
export const enableNamedHooksFeature = true;
19-
export const enableLogger = false;
20-
export const consoleManagedByDevToolsDuringStrictMode = true;

packages/react-devtools-shared/src/config/DevToolsFeatureFlags.extension-fb.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
* It should always be imported from "react-devtools-feature-flags".
1414
************************************************************************/
1515

16+
export const consoleManagedByDevToolsDuringStrictMode = true;
17+
export const enableLogger = true;
18+
export const enableNamedHooksFeature = true;
1619
export const enableProfilerChangedHookIndices = true;
20+
export const enableStyleXFeatures = true;
1721
export const isInternalFacebookBuild = true;
18-
export const enableNamedHooksFeature = true;
19-
export const enableLogger = true;
20-
export const consoleManagedByDevToolsDuringStrictMode = true;
2122

2223
/************************************************************************
2324
* Do not edit the code below.

packages/react-devtools-shared/src/config/DevToolsFeatureFlags.extension-oss.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
* It should always be imported from "react-devtools-feature-flags".
1414
************************************************************************/
1515

16+
export const consoleManagedByDevToolsDuringStrictMode = true;
17+
export const enableLogger = false;
18+
export const enableNamedHooksFeature = true;
1619
export const enableProfilerChangedHookIndices = true;
20+
export const enableStyleXFeatures = false;
1721
export const isInternalFacebookBuild = false;
18-
export const enableNamedHooksFeature = true;
19-
export const enableLogger = false;
20-
export const consoleManagedByDevToolsDuringStrictMode = true;
2122

2223
/************************************************************************
2324
* Do not edit the code below.

0 commit comments

Comments
 (0)