[POC] Warn on constant constructions coming from default params

This seems to work, but we would probably want to improve the error message for this case.

Author: captbaritone

packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js

@@ -7518,6 +7518,42 @@ const tests = {
         },
       ],
     },
+    {
+      only: true,
+      code: normalizeIndent`
+        function Foo({foo = []}) {
+          useEffect(() => {
+            console.log(foo);
+          }, [foo]);
+        }
+      `,
+      errors: [
+        {
+          message:
+            "The 'foo' array makes the dependencies of useEffect Hook (at line 5) change on every render. " +
+            "Move it inside the useEffect callback. Alternatively, wrap the initialization of 'foo' in its own useMemo() Hook.",
+          suggestions: undefined,
+        },
+      ],
+    },
+    {
+      only: true,
+      code: normalizeIndent`
+        function useFoo(foo = []) {
+          useEffect(() => {
+            console.log(foo);
+          }, [foo]);
+        }
+      `,
+      errors: [
+        {
+          message:
+            "The 'foo' array makes the dependencies of useEffect Hook (at line 5) change on every render. " +
+            "Move it inside the useEffect callback. Alternatively, wrap the initialization of 'foo' in its own useMemo() Hook.",
+          suggestions: undefined,
+        },
+      ],
+    },
   ],
 };
 

packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js

@@ -1474,11 +1474,27 @@ function scanForConstructions({
       if (node == null) {
         return null;
       }
+
+      // function(foo = []) {}
+      // function({foo = []}) {}
+      if (
+        node.type === 'Parameter' &&
+        node.name.parent.type === 'AssignmentPattern'
+      ) {
+        const constantExpressionType = getConstructionExpressionType(
+          node.name.parent.right,
+        );
+        if (constantExpressionType != null) {
+          return [ref, constantExpressionType];
+        }
+      }
+
       // const handleChange = function () {}
       // const handleChange = () => {}
       // const foo = {}
       // const foo = []
       // etc.
+
       if (
         node.type === 'Variable' &&
         node.node.type === 'VariableDeclarator' &&