[compiler] Allow extraneous non-reactive locals (#35190)

The existing exhaustive-deps rule allows omitting non-reactive
dependencies, even if they're not memoized. Conceptually, if a value is
non-reactive then it cannot semantically change. Even if the value is a
new object, that object represents the exact same value and doesn't
necessitate redoing downstream computation. Thus its fine to exclude
nonreactive dependencies, whether they're a stable type or not.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35190).
* #35201
* #35202
* #35192
* __->__ #35190

DiffTrain build for [67c1487](67c1487)

Author: josephsavona

compiled/eslint-plugin-react-hooks/index.js

@@ -53578,8 +53578,7 @@ function validateExhaustiveDependencies(fn) {
                 reason: 'Unexpected function dependency',
                 loc: value.loc,
             });
-            const isRequiredDependency = reactive.has(inferredDependency.identifier.id) ||
-                !isStableType(inferredDependency.identifier);
+            const isRequiredDependency = reactive.has(inferredDependency.identifier.id);
             let hasMatchingManualDependency = false;
             for (const manualDependency of manualDependencies) {
                 if (manualDependency.root.kind === 'NamedLocal' &&
@@ -53605,10 +53604,7 @@ function validateExhaustiveDependencies(fn) {
             extra.push(dep);
         }
         retainWhere(extra, dep => {
-            const isNonReactiveStableValue = dep.root.kind === 'NamedLocal' &&
-                !dep.root.value.reactive &&
-                isStableType(dep.root.value.identifier);
-            return !isNonReactiveStableValue;
+            return dep.root.kind === 'Global' || dep.root.value.reactive;
         });
         if (missing.length !== 0 || extra.length !== 0) {
             let suggestions = null;

compiled/facebook-www/REVISION

@@ -1 +1 @@
-454e01e603464b19ec3b6991a7a781cf1908ac84
+67c1487ffd872c95a3bb7d8104eac6eca79fe8cb

compiled/facebook-www/REVISION_TRANSFORMS

@@ -1 +1 @@
-454e01e603464b19ec3b6991a7a781cf1908ac84
+67c1487ffd872c95a3bb7d8104eac6eca79fe8cb

compiled/facebook-www/React-dev.classic.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-classic-454e01e6-20251124";
+    exports.version = "19.3.0-www-classic-67c1487f-20251124";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

@@ -1499,7 +1499,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.3.0-www-modern-454e01e6-20251124";
+    exports.version = "19.3.0-www-modern-67c1487f-20251124";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-454e01e6-20251124";
+exports.version = "19.3.0-www-classic-67c1487f-20251124";

compiled/facebook-www/React-prod.modern.js

@@ -606,4 +606,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-454e01e6-20251124";
+exports.version = "19.3.0-www-modern-67c1487f-20251124";

compiled/facebook-www/React-profiling.classic.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-classic-454e01e6-20251124";
+exports.version = "19.3.0-www-classic-67c1487f-20251124";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

@@ -610,7 +610,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.3.0-www-modern-454e01e6-20251124";
+exports.version = "19.3.0-www-modern-67c1487f-20251124";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

@@ -20468,10 +20468,10 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.3.0-www-classic-454e01e6-20251124",
+        version: "19.3.0-www-classic-67c1487f-20251124",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
-        reconcilerVersion: "19.3.0-www-classic-454e01e6-20251124"
+        reconcilerVersion: "19.3.0-www-classic-67c1487f-20251124"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -20506,7 +20506,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.3.0-www-classic-454e01e6-20251124";
+    exports.version = "19.3.0-www-classic-67c1487f-20251124";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&