Remove some web debugging remnants (#48054)

Summary:
Pull Request resolved: #48054

Web debugging should be fully removed as of recent, so lets remove some of the gunk that was powering it, and checks for that environment.

I did some string searches for the following:

* isAsyncDebugging
* debugRemotely
* isDebuggingRemotely
* isRemoteDebuggingAvailable
* WebSocketExecutor
* JavaJSExecutor
* ProxyJavaScriptExecutor
* RELOAD_APP_EXTRA_JS_PROXY
* getJSBundleURLForRemoteDebugging
* onReloadWithJSDebugger
* setRemoteJSDebugEnabled
* WebsocketJavaScriptExecutor
* createRemoteDebuggerBundleLoader

1. `expo-modules-core` exposes its own `isAsyncDebugging` by checking for `nativeCallSyncHook`, but does not depend on `DebugEnvironment`.
2. `expo-dev-menu` does read `isDebuggingRemotely` from `DevSettings`.
3. Realm does a check in Native using `objc_lookUpClass("RCTWebSocketExecutor")` but will gracefully handle `nil` if it does not exist
4. Some more usages (e.g. `onReloadWithJSDebugger`) in vendored packages of `expo-dev-launcher` for RN 0.74

I created an issue for Expo mentioning both here: expo/expo#33371

Changelog:
[General][Breaking] - Remove some web debugging remnants

Reviewed By: huntie

Differential Revision: D66553934

fbshipit-source-id: deec382b1c8bda393fddb8682aa91b26afd9fbe3

Author: NickGerleman

packages/react-native/Libraries/ReactNative/PaperUIManager.js

@@ -36,7 +36,6 @@ function getConstants(): Object {
 function getViewManagerConfig(viewManagerName: string): any {
   if (
     viewManagerConfigs[viewManagerName] === undefined &&
-    global.nativeCallSyncHook && // If we're in the Chrome Debugger, let's not even try calling the sync method
     NativeUIManager.getConstantsForViewManager
   ) {
     try {

packages/react-native/Libraries/Utilities/Appearance.js

@@ -14,7 +14,6 @@ import typeof INativeAppearance from './NativeAppearance';
 
 import NativeEventEmitter from '../EventEmitter/NativeEventEmitter';
 import EventEmitter from '../vendor/emitter/EventEmitter';
-import {isAsyncDebugging} from './DebugEnvironment';
 import invariant from 'invariant';
 
 type Appearance = {
@@ -74,13 +73,6 @@ function getState(): $NonMaybeType<typeof lazyState> {
  * the `useColorScheme` hook.
  */
 export function getColorScheme(): ?ColorSchemeName {
-  if (__DEV__) {
-    if (isAsyncDebugging) {
-      // Hard code light theme when using the async debugger as
-      // sync calls aren't supported
-      return 'light';
-    }
-  }
   let colorScheme = null;
   const state = getState();
   const {NativeAppearance} = state;

packages/react-native/Libraries/Utilities/DebugEnvironment.js

@@ -8863,11 +8863,6 @@ declare module.exports: TBackHandler;
 "
 `;
 
-exports[`public API should not change unintentionally Libraries/Utilities/DebugEnvironment.js 1`] = `
-"declare export let isAsyncDebugging: boolean;
-"
-`;
-
 exports[`public API should not change unintentionally Libraries/Utilities/DevLoadingView.js 1`] = `
 "declare module.exports: {
   showMessage(message: string, type: \\"load\\" | \\"refresh\\"): void,
@@ -10307,7 +10302,6 @@ exports[`public API should not change unintentionally src/private/specs/modules/
 "export interface Spec extends TurboModule {
   +show: () => void;
   +reload: () => void;
-  +debugRemotely: (enableDebug: boolean) => void;
   +setProfilingEnabled: (enabled: boolean) => void;
   +setHotLoadingEnabled: (enabled: boolean) => void;
 }
@@ -10321,7 +10315,6 @@ exports[`public API should not change unintentionally src/private/specs/modules/
   +reloadWithReason?: (reason: string) => void;
   +onFastRefresh?: () => void;
   +setHotLoadingEnabled: (isHotLoadingEnabled: boolean) => void;
-  +setIsDebuggingRemotely: (isDebuggingRemotelyEnabled: boolean) => void;
   +setProfilingEnabled: (isProfilingEnabled: boolean) => void;
   +toggleElementInspector: () => void;
   +addMenuItem: (title: string) => void;

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

@@ -50,7 +50,6 @@ Class RCTRedBoxCls(void) __attribute__((used));
 Class RCTSourceCodeCls(void) __attribute__((used));
 Class RCTStatusBarManagerCls(void) __attribute__((used));
 Class RCTTimingCls(void) __attribute__((used));
-Class RCTWebSocketExecutorCls(void) __attribute__((used));
 Class RCTWebSocketModuleCls(void) __attribute__((used));
 Class RCTBlobManagerCls(void) __attribute__((used));
 

packages/react-native/React/CoreModules/CoreModulesPlugins.h

@@ -40,7 +40,6 @@ Class RCTCoreModulesClassProvider(const char *name) {
     {"SourceCode", RCTSourceCodeCls},
     {"StatusBarManager", RCTStatusBarManagerCls},
     {"Timing", RCTTimingCls},
-    {"WebSocketExecutor", RCTWebSocketExecutorCls},
     {"WebSocketModule", RCTWebSocketModuleCls},
     {"BlobModule", RCTBlobManagerCls},
   };

packages/react-native/React/CoreModules/CoreModulesPlugins.mm

@@ -152,14 +152,6 @@ - (void)registerHotkeys
                                    [(RCTDevSettings *)[weakSelf.moduleRegistry moduleForName:"DevSettings"]
                                        toggleElementInspector];
                                  }];
-
-  // Reload in normal mode
-  [commands registerKeyCommandWithInput:@"n"
-                          modifierFlags:UIKeyModifierCommand
-                                 action:^(__unused UIKeyCommand *command) {
-                                   [(RCTDevSettings *)[weakSelf.moduleRegistry moduleForName:"DevSettings"]
-                                       setIsDebuggingRemotely:NO];
-                                 }];
 #endif
 }
 
@@ -456,12 +448,6 @@ - (BOOL)shakeToShow
   RCTTriggerReloadCommandListeners(@"Unknown from JS");
 }
 
-RCT_EXPORT_METHOD(debugRemotely : (BOOL)enableDebug)
-{
-  WARN_DEPRECATED_DEV_MENU_EXPORT();
-  ((RCTDevSettings *)[_moduleRegistry moduleForName:"DevSettings"]).isDebuggingRemotely = enableDebug;
-}
-
 RCT_EXPORT_METHOD(setProfilingEnabled : (BOOL)enabled)
 {
   WARN_DEPRECATED_DEV_MENU_EXPORT();
@@ -526,10 +512,6 @@ - (void)addItem:(RCTDevMenu *)item
 {
 }
 
-- (void)debugRemotely:(BOOL)enableDebug
-{
-}
-
 - (BOOL)isActionSheetShown
 {
   return NO;

packages/react-native/React/CoreModules/RCTDevMenu.mm

@@ -47,14 +47,8 @@
 - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;
 
 @property (nonatomic, readonly) BOOL isHotLoadingAvailable;
-@property (nonatomic, readonly) BOOL isRemoteDebuggingAvailable;
 @property (nonatomic, readonly) BOOL isDeviceDebuggingAvailable;
 
-/**
- * Whether the bridge is connected to a remote JS executor.
- */
-@property (nonatomic, assign) BOOL isDebuggingRemotely;
-
 /*
  * Whether shaking will show RCTDevMenu. The menu is enabled by default if RCT_DEV=1, but
  * you may wish to disable it so that you can provide your own shake handler.

packages/react-native/React/CoreModules/RCTDevSettings.h

@@ -27,7 +27,6 @@
 static NSString *const kRCTDevSettingProfilingEnabled = @"profilingEnabled";
 static NSString *const kRCTDevSettingHotLoadingEnabled = @"hotLoadingEnabled";
 static NSString *const kRCTDevSettingIsInspectorShown = @"showInspector";
-static NSString *const kRCTDevSettingIsDebuggingRemotely = @"isDebuggingRemotely";
 static NSString *const kRCTDevSettingExecutorOverrideClass = @"executor-override";
 static NSString *const kRCTDevSettingShakeToShowDevMenu = @"shakeToShow";
 static NSString *const kRCTDevSettingIsPerfMonitorShown = @"RCTPerfMonitorKey";
@@ -124,9 +123,6 @@ - (void)_reloadWithDefaults:(NSDictionary *)defaultValues
 
 @interface RCTDevSettings () <RCTBridgeModule, RCTInvalidating, NativeDevSettingsSpec, RCTDevSettingsInspectable> {
   BOOL _isJSLoaded;
-#if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION
-  RCTHandlerToken _bridgeExecutorOverrideToken;
-#endif
 }
 
 @property (nonatomic, strong) Class executorClass;
@@ -183,18 +179,6 @@ - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource
 - (void)initialize
 {
 #if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION
-  if ([self _isBridgeMode]) {
-    RCTBridge *__weak weakBridge = self.bridge;
-    _bridgeExecutorOverrideToken = [[RCTPackagerConnection sharedPackagerConnection]
-        addNotificationHandler:^(id params) {
-          if (params != (id)kCFNull && [params[@"debug"] boolValue]) {
-            weakBridge.executorClass = objc_lookUpClass("RCTWebSocketExecutor");
-          }
-        }
-                         queue:dispatch_get_main_queue()
-                     forMethod:@"reload"];
-  }
-
   if (numInitializedModules++ == 0) {
     reloadToken = [[RCTPackagerConnection sharedPackagerConnection]
         addNotificationHandler:^(id params) {
@@ -255,10 +239,6 @@ - (void)invalidate
 {
   [super invalidate];
 #if RCT_DEV_SETTINGS_ENABLE_PACKAGER_CONNECTION
-  if ([self _isBridgeMode]) {
-    [[RCTPackagerConnection sharedPackagerConnection] removeHandler:_bridgeExecutorOverrideToken];
-  }
-
   if (--numInitializedModules == 0) {
     [[RCTPackagerConnection sharedPackagerConnection] removeHandler:reloadToken];
 #if RCT_DEV_MENU
@@ -296,15 +276,6 @@ - (BOOL)isDeviceDebuggingAvailable
 #endif // RCT_ENABLE_INSPECTOR
 }
 
-- (BOOL)isRemoteDebuggingAvailable
-{
-  if (RCTTurboModuleEnabled()) {
-    return NO;
-  }
-  Class jsDebuggingExecutorClass = objc_lookUpClass("RCTWebSocketExecutor");
-  return (jsDebuggingExecutorClass != nil);
-}
-
 - (BOOL)isHotLoadingAvailable
 {
   if (self.bundleManager.bundleURL) {
@@ -338,30 +309,6 @@ - (BOOL)isShakeToShowDevMenuEnabled
   return [[self settingForKey:kRCTDevSettingShakeToShowDevMenu] boolValue];
 }
 
-RCT_EXPORT_METHOD(setIsDebuggingRemotely : (BOOL)enabled)
-{
-  [self _updateSettingWithValue:@(enabled) forKey:kRCTDevSettingIsDebuggingRemotely];
-  [self _remoteDebugSettingDidChange];
-}
-
-- (BOOL)isDebuggingRemotely
-{
-  return [[self settingForKey:kRCTDevSettingIsDebuggingRemotely] boolValue];
-}
-
-- (void)_remoteDebugSettingDidChange
-{
-  // This value is passed as a command-line argument, so fall back to reading from NSUserDefaults directly
-  NSString *executorOverride = [[NSUserDefaults standardUserDefaults] stringForKey:kRCTDevSettingExecutorOverrideClass];
-  Class executorOverrideClass = executorOverride ? NSClassFromString(executorOverride) : nil;
-  if (executorOverrideClass) {
-    self.executorClass = executorOverrideClass;
-  } else {
-    BOOL enabled = self.isRemoteDebuggingAvailable && self.isDebuggingRemotely;
-    self.executorClass = enabled ? objc_getClass("RCTWebSocketExecutor") : nil;
-  }
-}
-
 RCT_EXPORT_METHOD(setProfilingEnabled : (BOOL)enabled)
 {
   [self _updateSettingWithValue:@(enabled) forKey:kRCTDevSettingProfilingEnabled];
@@ -460,7 +407,7 @@ - (void)setExecutorClass:(Class)executorClass
     // support for custom executors in the dev menu. But right now this is
     // needed to prevent overriding a custom executor with the default if a
     // custom executor has been set directly on the bridge
-    if (executorClass == Nil && self.bridge.executorClass != objc_lookUpClass("RCTWebSocketExecutor")) {
+    if (executorClass == Nil) {
       return;
     }
 
@@ -518,7 +465,6 @@ - (void)setupHMRClientWithAdditionalBundleURL:(NSURL *)bundleURL
  */
 - (void)_synchronizeAllSettings
 {
-  [self _remoteDebugSettingDidChange];
   [self _profilingSettingDidChange];
 }
 
@@ -578,10 +524,6 @@ - (BOOL)isHotLoadingAvailable
 {
   return NO;
 }
-- (BOOL)isRemoteDebuggingAvailable
-{
-  return NO;
-}
 + (BOOL)requiresMainQueueSetup
 {
   return NO;
@@ -602,9 +544,6 @@ - (void)onFastRefresh
 - (void)setHotLoadingEnabled:(BOOL)isHotLoadingEnabled
 {
 }
-- (void)setIsDebuggingRemotely:(BOOL)isDebuggingRemotelyEnabled
-{
-}
 - (void)setProfilingEnabled:(BOOL)isProfilingEnabled
 {
 }