Commit 767f8e0
Add bots as a yarn workspace and update danger action (#34652)
Summary:
allow-large-files
When working on #34614, danger is failing because it doesn't share `node_modules` with the root directory where `typescript` is installed as we added it as a parser in our eslint config.
By setting `bots` as a yarn workspace, dependencies are all installed under the root `node_modules` folder and in local testing (detailed in test section) we no longer have the `typescript module not found` error. However, danger will continue to fail on #34614 as the `danger_pr` Github action runs from what's defined on `main`.
Once these changes land, I can rebase #34614 on it and danger's eslint should pass.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal][Fixed] - Add `bots` directory as a yarn workspace and update `danger_pr` Github action
Pull Request resolved: #34652
Test Plan:
To verify this fix I had to run:
```
react-native $ yarn && cd bots
react-native/bots$ yarn run danger pr #34614
```
which resulted in
```
❯ yarn run danger pr #34614
yarn run v1.22.19
$ lunaleaps/react-native/node_modules/.bin/danger pr #34614
Starting Danger PR on #34614
Danger: ✓ found only warnings, not failing the build
## Warnings
:lock: package.json - <i>Changes were made to package.json. This will require a manual import by a Facebook employee.</i>
✨ Done in 12.78s.
```
Verified this also on another PR:
```
yarn run danger pr #34650
```
Reviewed By: NickGerleman
Differential Revision: D39435286
Pulled By: lunaleaps
fbshipit-source-id: 8c82f49facf162f4fc0918e3abd95eb7e4ad1e371 parent bfb36c2 commit 767f8e0
File tree
13 files changed
+1331
-1711
lines changed- .circleci
- .github/workflows
- bots
- packages/react-native-bots
13 files changed
+1331
-1711
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | 176 | | |
183 | 177 | | |
184 | 178 | | |
| |||
247 | 241 | | |
248 | 242 | | |
249 | 243 | | |
250 | | - | |
251 | 244 | | |
252 | 245 | | |
253 | 246 | | |
| |||
304 | 297 | | |
305 | 298 | | |
306 | 299 | | |
307 | | - | |
308 | 300 | | |
309 | 301 | | |
310 | 302 | | |
| |||
1291 | 1283 | | |
1292 | 1284 | | |
1293 | 1285 | | |
1294 | | - | |
1295 | 1286 | | |
1296 | 1287 | | |
1297 | 1288 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | 23 | | |
27 | 24 | | |
28 | | - | |
| 25 | + | |
29 | 26 | | |
30 | 27 | | |
0 commit comments