Skip to content

Commit 73747e6

Browse files
PaitoAndersonkelset
authored andcommitted
Fix iOS Image.getSizeWithHeaders (#29338)
Summary: Fixes #28632 Image.getSizeWithHeaders() was not working as intended on iOS. ## Changelog [iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`. Pull Request resolved: #29338 Test Plan: Used RNTester and an Image URL requiring a Bearer token to test. Code: <img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png"> With Bearer Token: <img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png"> Without Bearer Token: <img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png"> Reviewed By: cpojer Differential Revision: D22783037 Pulled By: PeteTheHeat fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
1 parent 2c5d4cb commit 73747e6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Libraries/Image/RCTImageLoader.mm

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1152,7 +1152,11 @@ - (void)cancelRequest:(id)requestToken
11521152
resolve:(RCTPromiseResolveBlock)resolve
11531153
reject:(RCTPromiseRejectBlock)reject)
11541154
{
1155-
NSURLRequest *request = [RCTConvert NSURLRequest:uri];
1155+
NSURL *URL = [RCTConvert NSURL:uri];
1156+
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:URL];
1157+
[headers enumerateKeysAndObjectsUsingBlock:^(NSString *key, id value, BOOL *stop) {
1158+
[request addValue:[RCTConvert NSString:value] forHTTPHeaderField:key];
1159+
}];
11561160
[self getImageSizeForURLRequest:request
11571161
block:^(NSError *error, CGSize size) {
11581162
if (error) {

0 commit comments

Comments
 (0)