enable render debug strings to opt mode

Summary:
Changelog: [Internal]
This helps us test with opt mode enabled as its the only one available for coverage.

Differential Revision: D87346884

Author: andrewdacenko

packages/react-native/Libraries/Components/View/__tests__/View-itest.js

@@ -5,6 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  *
  * @flow strict-local
+ * @fantom_mode opt
  * @fantom_flags enableNativeCSSParsing:*
  * @format
  */

packages/react-native/ReactCommon/react/renderer/debug/CMakeLists.txt

@@ -15,3 +15,10 @@ target_include_directories(react_renderer_debug PUBLIC ${REACT_COMMON_DIR})
 target_link_libraries(react_renderer_debug folly_runtime react_debug)
 target_compile_reactnative_options(react_renderer_debug PRIVATE)
 target_compile_options(react_renderer_debug PRIVATE -Wpedantic)
+
+# Enable debug string convertible for Debug builds or when explicitly requested
+# This allows getRenderedOutput() to include props in tests
+# Set REACT_NATIVE_ENABLE_DEBUG_STRING_CONVERTIBLE=ON to enable for Release builds
+if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_ENABLE_DEBUG_STRING_CONVERTIBLE)
+  target_compile_definitions(react_renderer_debug PUBLIC RN_DEBUG_STRING_CONVERTIBLE=1)
+endif()

packages/react-native/ReactCommon/react/renderer/debug/flags.h

@@ -29,12 +29,15 @@
 // #define RN_SHADOW_TREE_INTROSPECTION 1
 
 // This enables certain object-to-string debug conversions to be compiled.
-// Enable if `REACT_NATIVE_DEBUG` is enabled.
+// Enable if `REACT_NATIVE_DEBUG` is enabled. Define RN_DEBUG_STRING_CONVERTIBLE
+// if you want to override this behavior.
+#ifndef RN_DEBUG_STRING_CONVERTIBLE
 #ifdef REACT_NATIVE_DEBUG
 #define RN_DEBUG_STRING_CONVERTIBLE 1
 #else
 #define RN_DEBUG_STRING_CONVERTIBLE 0
 #endif
+#endif
 
 // Enables *very* verbose, noisy logs in the differ. Useful for debugging
 // specifically the differ, but not much else.

private/react-native-fantom/build.gradle.kts

@@ -188,6 +188,7 @@ val configureFantomTester by
               "-DREACT_COMMON_DIR=$reactNativeDir/ReactCommon",
               "-DREACT_CXX_PLATFORM_DIR=$reactNativeDir/ReactCxxPlatform",
               "-DREACT_THIRD_PARTY_NDK_DIR=$reactAndroidBuildDir/third-party-ndk",
+              "-DREACT_NATIVE_ENABLE_DEBUG_STRING_CONVERTIBLE=ON",
           )
       commandLine(cmdArgs)
       standardOutputFile.set(project.file("$buildDir/reports/configure-fantom_tester.log"))

private/react-native-fantom/runner/utils.js

@@ -101,7 +101,11 @@ export function getBuckModesForPlatform(
       throw new Error(`Unsupported platform: ${os.platform()}`);
   }
 
-  return ['@//xplat/mode/react-native/granite', osPlatform];
+  return [
+    '@//xplat/mode/react-native/granite',
+    '@//xplat/mode/react-native/enable_debug_string_convertible',
+    osPlatform,
+  ];
 }
 
 // TODO: T240293839 Remove when we get rid of RN_USE_ANIMATION_BACKEND preprocessor flag