Fix for broken test_helloworld_android on Release (#44952)

cortinico · facebook-github-bot · commit 2b640bec3404 · 2024-06-14T11:11:20.000-07:00
Summary: Pull Request resolved: #44952 The test_helloworld_android Release variant are broken on GHA. This fixes it as it forces hermesc to be built *before* the app attempts to create a bundle. Changelog: [Internal] [Changed] - Fix for broken test_helloworld_android on Release Reviewed By: cipolleschi, blakef Differential Revision: D58591480 fbshipit-source-id: 2afc1cfe8c416da6f5919d20098639653798dd1a
diff --git a/packages/helloworld/android/app/build.gradle b/packages/helloworld/android/app/build.gradle
@@ -137,3 +137,11 @@ dependencies {
         implementation jscFlavor
     }
 }
+
+afterEvaluate {
+    // As HelloWorld is building from source, we need to make sure hermesc is built before the JS bundle is created.
+    // Otherwise the release version of the app will fail to build due to missing hermesc.
+    tasks
+        .getByName("createBundleReleaseJsAndAssets")
+        .dependsOn(gradle.includedBuild("react-native").task(":packages:react-native:ReactAndroid:hermes-engine:buildHermesC"))
+}

Original file line number	Diff line number	Diff line change
`@@ -137,3 +137,11 @@ dependencies {`
`137`	`137`	`implementation jscFlavor`
`138`	`138`	`}`
`139`	`139`	`}`
	`140`	`+`
	`141`	`+afterEvaluate {`
	`142`	`+ // As HelloWorld is building from source, we need to make sure hermesc is built before the JS bundle is created.`
	`143`	`+ // Otherwise the release version of the app will fail to build due to missing hermesc.`
	`144`	`+ tasks`
	`145`	`+ .getByName("createBundleReleaseJsAndAssets")`
	`146`	`+ .dependsOn(gradle.includedBuild("react-native").task(":packages:react-native:ReactAndroid:hermes-engine:buildHermesC"))`
	`147`	`+}`