Run eslint --fix

Summary:
CI is currently failing because of a lint issue, this fixes it and a bunch of other warnings that are auto-fixable.

**Test plan**
Quick manual test, cosmetic changes only.
Closes #16229

Differential Revision: D6009748

Pulled By: TheSavior

fbshipit-source-id: cabd44fed99dd90bd0b35626492719c139c89f34

Author: janicduplessis

ContainerShip/scripts/run-android-ci-instrumentation-tests.js

@@ -45,7 +45,7 @@ const test_opts = {
 
     OFFSET: argv.offset,
     COUNT: argv.count
-}
+};
 
 let max_test_class_length = Number.NEGATIVE_INFINITY;
 
@@ -85,14 +85,14 @@ if (test_opts.COUNT != null && test_opts.OFFSET != null) {
 }
 
 return async.mapSeries(testClasses, (clazz, callback) => {
-    if(clazz.length > max_test_class_length) {
+    if (clazz.length > max_test_class_length) {
         max_test_class_length = clazz.length;
     }
 
     return async.retry(test_opts.RETRIES, (retryCb) => {
         const test_process = child_process.spawn('./ContainerShip/scripts/run-instrumentation-tests-via-adb-shell.sh', [test_opts.PACKAGE, clazz], {
             stdio: 'inherit'
-        })
+        });
 
         const timeout = setTimeout(() => {
             test_process.kill();
@@ -106,7 +106,7 @@ return async.mapSeries(testClasses, (clazz, callback) => {
         test_process.on('exit', (code) => {
             clearTimeout(timeout);
 
-            if(code !== 0) {
+            if (code !== 0) {
                 return retryCb(new Error(`Process exited with code: ${code}`));
             }
 
@@ -138,16 +138,16 @@ function print_test_suite_results(results) {
     function pad_output(num_chars) {
         let i = 0;
 
-        while(i < num_chars) {
+        while (i < num_chars) {
             process.stdout.write(' ');
             i++;
         }
     }
     results.forEach((test) => {
-        if(test.status === 'success') {
+        if (test.status === 'success') {
             color = colors.GREEN;
             passing_suites++;
-        } else if(test.status === 'failure') {
+        } else if (test.status === 'failure') {
             color = colors.RED;
             failing_suites++;
         }

IntegrationTests/AsyncStorageTest.js

@@ -155,7 +155,7 @@ function testOptimizedMultiGet() {
   let keys = batch.map(([key, value]) => key);
   AsyncStorage.multiSet(batch, (err1) => {
     // yes, twice on purpose
-    ;[1, 2].forEach((i) => {
+    [1, 2].forEach((i) => {
       expectAsyncNoError(`${i} testOptimizedMultiGet/multiSet`, err1);
       AsyncStorage.multiGet(keys, (err2, result) => {
         expectAsyncNoError(`${i} testOptimizedMultiGet/multiGet`, err2);

IntegrationTests/ImageCachePolicyTest.js

@@ -48,7 +48,7 @@ class ImageCachePolicyTest extends React.Component<Props, $FlowFixMeState> {
     const results: Array<?boolean> = TESTS.map(x => nextState[x]);
 
     if (!results.includes(undefined)) {
-      const result: boolean = results.reduce((x,y) => x === y === true, true)
+      const result: boolean = results.reduce((x,y) => x === y === true, true);
       TestModule.markTestPassed(result);
     }
 

Libraries/Components/ScrollResponder.js

@@ -548,7 +548,7 @@ var ScrollResponderMixin = {
     warning(
       typeof keyboardShouldPersistTaps !== 'boolean',
       `'keyboardShouldPersistTaps={${keyboardShouldPersistTaps}}' is deprecated. `
-      + `Use 'keyboardShouldPersistTaps="${keyboardShouldPersistTaps ? "always" : "never"}"' instead`
+      + `Use 'keyboardShouldPersistTaps="${keyboardShouldPersistTaps ? 'always' : 'never'}"' instead`
     );
 
     this.keyboardWillOpenTo = null;

Libraries/Components/Touchable/TouchableHighlight.js

@@ -138,7 +138,7 @@ const PRESS_RETENTION_OFFSET = {top: 20, left: 20, right: 20, bottom: 30};
  *
  * AppRegistry.registerComponent('App', () => App)
  * ```
- * 
+ *
  */
 
 var TouchableHighlight = createReactClass({

Libraries/Components/WebView/WebView.ios.js

@@ -377,7 +377,7 @@ class WebView extends React.Component {
       'always',
       'compatibility'
     ]),
-    
+
     /**
      * Override the native component used to render the WebView. Enables a custom native
      * WebView which uses the same JavaScript as the original WebView.

Libraries/Core/Devtools/symbolicateStackTrace.js

@@ -16,7 +16,7 @@ const getDevServer = require('getDevServer');
 const {SourceCode} = require('NativeModules');
 
 // Avoid requiring fetch on load of this module; see symbolicateStackTrace
-let fetch; 
+let fetch;
 
 import type {StackFrame} from 'parseErrorStack';
 
@@ -25,13 +25,13 @@ function isSourcedFromDisk(sourcePath: string): boolean {
 }
 
 async function symbolicateStackTrace(stack: Array<StackFrame>): Promise<Array<StackFrame>> {
-  // RN currently lazy loads whatwg-fetch using a custom fetch module, which, 
+  // RN currently lazy loads whatwg-fetch using a custom fetch module, which,
   // when called for the first time, requires and re-exports 'whatwg-fetch'.
-  // However, when a dependency of the project tries to require whatwg-fetch 
-  // either directly or indirectly, whatwg-fetch is required before 
+  // However, when a dependency of the project tries to require whatwg-fetch
+  // either directly or indirectly, whatwg-fetch is required before
   // RN can lazy load whatwg-fetch. As whatwg-fetch checks
-  // for a fetch polyfill before loading, it will in turn try to load 
-  // RN's fetch module, which immediately tries to import whatwg-fetch AGAIN. 
+  // for a fetch polyfill before loading, it will in turn try to load
+  // RN's fetch module, which immediately tries to import whatwg-fetch AGAIN.
   // This causes a circular require which results in RN's fetch module
   // exporting fetch as 'undefined'.
   // The fix below postpones trying to load fetch until the first call to symbolicateStackTrace.

Libraries/Utilities/Dimensions.js

@@ -107,7 +107,7 @@ class Dimensions {
     handler: Function
   ) {
     invariant(
-      'change' === type,
+      type === 'change',
       'Trying to subscribe to unknown event: "%s"', type
     );
     eventEmitter.addListener(type, handler);
@@ -121,7 +121,7 @@ class Dimensions {
     handler: Function
   ) {
     invariant(
-      'change' === type,
+      type === 'change',
       'Trying to remove listener for unknown event: "%s"', type
     );
     eventEmitter.removeListener(type, handler);

Libraries/Utilities/PixelRatio.js

@@ -29,33 +29,33 @@ var Dimensions = require('Dimensions');
  * });
  * <Image source={image} style={{width: 200, height: 100}} />
  * ```
- * 
+ *
  * ## Pixel grid snapping
- * 
- * In iOS, you can specify positions and dimensions for elements with arbitrary 
+ *
+ * In iOS, you can specify positions and dimensions for elements with arbitrary
  * precision, for example 29.674825. But, ultimately the physical display only
  * have a fixed number of pixels, for example 640×960 for iPhone 4 or 750×1334
- * for iPhone 6. iOS tries to be as faithful as possible to the user value by 
- * spreading one original pixel into multiple ones to trick the eye. The 
- * downside of this technique is that it makes the resulting element look 
+ * for iPhone 6. iOS tries to be as faithful as possible to the user value by
+ * spreading one original pixel into multiple ones to trick the eye. The
+ * downside of this technique is that it makes the resulting element look
  * blurry.
- * 
- * In practice, we found out that developers do not want this feature and they 
- * have to work around it by doing manual rounding in order to avoid having 
- * blurry elements. In React Native, we are rounding all the pixels 
+ *
+ * In practice, we found out that developers do not want this feature and they
+ * have to work around it by doing manual rounding in order to avoid having
+ * blurry elements. In React Native, we are rounding all the pixels
  * automatically.
- * 
- * We have to be careful when to do this rounding. You never want to work with 
- * rounded and unrounded values at the same time as you're going to accumulate 
- * rounding errors. Having even one rounding error is deadly because a one 
+ *
+ * We have to be careful when to do this rounding. You never want to work with
+ * rounded and unrounded values at the same time as you're going to accumulate
+ * rounding errors. Having even one rounding error is deadly because a one
  * pixel border may vanish or be twice as big.
- * 
+ *
  * In React Native, everything in JavaScript and within the layout engine works
- * with arbitrary precision numbers. It's only when we set the position and 
- * dimensions of the native element on the main thread that we round. Also, 
- * rounding is done relative to the root rather than the parent, again to avoid 
+ * with arbitrary precision numbers. It's only when we set the position and
+ * dimensions of the native element on the main thread that we round. Also,
+ * rounding is done relative to the root rather than the parent, again to avoid
  * accumulating rounding errors.
- * 
+ *
  */
 class PixelRatio {
   /**

Libraries/Utilities/RCTLog.js

@@ -51,6 +51,6 @@ const RCTLog = {
   setWarningHandler(handler: typeof warningHandler): void {
     warningHandler = handler;
   }
-}
+};
 
 module.exports = RCTLog;