Review feedback: Renames and build fix

Author: huntie

config/gni/devtools_grd_files.gni

@@ -1941,10 +1941,11 @@ grd_files_debug_sources = [
   "front_end/panels/timeline/components/NetworkThrottlingSelector.js",
   "front_end/panels/timeline/components/OriginMap.js",
   "front_end/panels/timeline/components/RelatedInsightChips.js",
+  "front_end/panels/timeline/components/RNPerfIssueTypes.js",
   "front_end/panels/timeline/components/Sidebar.js",
   "front_end/panels/timeline/components/SidebarAnnotationsTab.js",
   "front_end/panels/timeline/components/SidebarInsightsTab.js",
-  "front_end/panels/timeline/components/SidebarRNPerfIssuesTab.js",
+  "front_end/panels/timeline/components/SidebarRNPerfSignalsTab.js",
   "front_end/panels/timeline/components/SidebarRNPerfIssueItem.js",
   "front_end/panels/timeline/components/SidebarSingleInsightSet.js",
   "front_end/panels/timeline/components/TimelineSummary.js",

front_end/panels/timeline/components/BUILD.gn

@@ -55,7 +55,7 @@ devtools_module("components") {
     "SidebarAnnotationsTab.ts",
     "SidebarInsightsTab.ts",
     "SidebarRNPerfIssueItem.ts",
-    "SidebarRNPerfIssuesTab.ts",
+    "SidebarRNPerfSignalsTab.ts",
     "SidebarSingleInsightSet.ts",
     "TimelineSummary.ts",
     "Utils.ts",

front_end/panels/timeline/components/Sidebar.ts

@@ -9,7 +9,7 @@ import * as UI from '../../../ui/legacy/legacy.js';
 
 import {SidebarAnnotationsTab} from './SidebarAnnotationsTab.js';
 import {SidebarInsightsTab} from './SidebarInsightsTab.js';
-import {SidebarRNPerfIssuesTab} from './SidebarRNPerfIssuesTab.js';
+import {SidebarRNPerfSignalsTab} from './SidebarRNPerfSignalsTab.js';
 
 export interface ActiveInsight {
   model: Trace.Insights.Types.InsightModel;
@@ -41,7 +41,7 @@ declare global {
 export const enum SidebarTabs {
   INSIGHTS = 'insights',
   ANNOTATIONS = 'annotations',
-  PERF_ISSUES = 'perf-issues',
+  PERF_SIGNALS = 'perf-signals',
 }
 export const DEFAULT_SIDEBAR_TAB = SidebarTabs.INSIGHTS;
 
@@ -55,7 +55,7 @@ export class SidebarWidget extends UI.Widget.VBox {
   #annotationsView = new AnnotationsView();
 
   #perfIssuesTabEnabled = false;
-  #rnPerfIssuesView = new RNPerfIssuesView();
+  #rnPerfSignalsView = new RNPerfSignalsView();
 
   /**
    * Track if the user has opened the sidebar before. We do this so that the
@@ -121,25 +121,25 @@ export class SidebarWidget extends UI.Widget.VBox {
 
   setParsedTrace(parsedTrace: Trace.Handlers.Types.ParsedTrace|null, metadata: Trace.Types.File.MetaData|null): void {
     this.#insightsView.setParsedTrace(parsedTrace, metadata);
-    this.#rnPerfIssuesView.setParsedTrace(parsedTrace);
+    this.#rnPerfSignalsView.setParsedTrace(parsedTrace);
 
     // [RN] Show or remove the Perf Issues tab if there are issues present
     if (this.#perfIssuesTabEnabled) {
-      const hasIssues = this.#rnPerfIssuesView.hasIssues();
-      const tabExists = this.#tabbedPane.hasTab(SidebarTabs.PERF_ISSUES);
+      const hasIssues = this.#rnPerfSignalsView.hasIssues();
+      const tabExists = this.#tabbedPane.hasTab(SidebarTabs.PERF_SIGNALS);
 
       if (hasIssues && !tabExists) {
         this.#tabbedPane.appendTab(
-            SidebarTabs.PERF_ISSUES, 'Performance Signals', this.#rnPerfIssuesView, undefined, undefined, false, true);
-        this.#tabbedPane.selectTab(SidebarTabs.PERF_ISSUES);
+            SidebarTabs.PERF_SIGNALS, 'Performance Signals', this.#rnPerfSignalsView, undefined, undefined, false, true);
+        this.#tabbedPane.selectTab(SidebarTabs.PERF_SIGNALS);
       } else if (!hasIssues && tabExists) {
-        this.#tabbedPane.closeTab(SidebarTabs.PERF_ISSUES);
+        this.#tabbedPane.closeTab(SidebarTabs.PERF_SIGNALS);
       }
     }
   }
 
   setSelectTimelineEventCallback(callback: (event: Trace.Types.Events.Event) => void): void {
-    this.#rnPerfIssuesView.setSelectTimelineEventCallback(callback);
+    this.#rnPerfSignalsView.setSelectTimelineEventCallback(callback);
   }
 
   setInsights(insights: Trace.Insights.Types.TraceInsightSets|null): void {
@@ -212,13 +212,13 @@ class AnnotationsView extends UI.Widget.VBox {
   }
 }
 
-/** [RN] Experimental view for Performance Issues. */
-class RNPerfIssuesView extends UI.Widget.VBox {
-  #component = new SidebarRNPerfIssuesTab();
+/** [RN] Experimental view for Performance Signals. */
+class RNPerfSignalsView extends UI.Widget.VBox {
+  #component = new SidebarRNPerfSignalsTab();
 
   constructor() {
     super();
-    this.element.classList.add('sidebar-perf-issues');
+    this.element.classList.add('sidebar-perf-signals');
     this.element.appendChild(this.#component);
   }
 

…ine/components/SidebarRNPerfIssuesTab.ts …ne/components/SidebarRNPerfSignalsTab.tsfront_end/panels/timeline/components/SidebarRNPerfIssuesTab.ts renamed to front_end/panels/timeline/components/SidebarRNPerfSignalsTab.ts front_end/panels/timeline/components/SidebarRNPerfIssuesTab.ts renamed to front_end/panels/timeline/components/SidebarRNPerfSignalsTab.ts

@@ -31,10 +31,10 @@ const UIStrings = {
   emptyStateDetail: 'No issues found',
 } as const;
 
-const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/SidebarRNPerfIssuesTab.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('panels/timeline/components/SidebarRNPerfSignalsTab.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export class SidebarRNPerfIssuesTab extends HTMLElement {
+export class SidebarRNPerfSignalsTab extends HTMLElement {
   readonly #boundRender = this.#render.bind(this);
   readonly #shadow = this.attachShadow({mode: 'open'});
 
@@ -162,10 +162,10 @@ export class SidebarRNPerfIssuesTab extends HTMLElement {
   }
 }
 
-customElements.define('devtools-performance-sidebar-perf-issues', SidebarRNPerfIssuesTab);
+customElements.define('devtools-performance-sidebar-perf-signals', SidebarRNPerfSignalsTab);
 
 declare global {
   interface HTMLElementTagNameMap {
-    'devtools-performance-sidebar-perf-issues': SidebarRNPerfIssuesTab;
+    'devtools-performance-sidebar-perf-signals': SidebarRNPerfSignalsTab;
   }
 }

scripts/eslint_rules/lib/check-license-header.js

@@ -88,7 +88,7 @@ const META_CODE_PATHS = [
   'panels/timeline/ReactNativeTimelineLandingPage.ts',
   'panels/timeline/components/RNPerfIssueTypes.ts',
   'panels/timeline/components/SidebarRNPerfIssueItem.ts',
-  'panels/timeline/components/SidebarRNPerfIssuesTab.ts',
+  'panels/timeline/components/SidebarRNPerfSignalsTab.ts',
 ];
 
 const OTHER_LICENSE_HEADERS = [