Pin babel-preset-react-app to to core-js minor '3.5' version and add a peer dependency

[Mrman]

• Specified the minor version as recommended by core-js docs
• Removed comment about core-js@3 upgrade
• Added peer dependency on core-js from babel-preset-react-app.

Did some due dilligence and see react-error-overlay and react-scripts both directly depend on babel-preset-react-app but do not have a direct dependency on core-js. They do both have direct dependencies on react-app-polyfill that in turn depends on core-js.

From my testing:

• npm doesn't complain about the peer depenency being unmet, guessing because it sees core-js in the dependency tree from react-app-polyfill
• yarn does warn about the peer dependency being unmet, this seems more correct than npm's behaviour.

Forgive my ignorance but I don't know if babel-preset-react-app is expected to be usable without core-js? If not does that suggest react-scripts and react-error-overlay should have a direct dependency on core-js too?

closes #8875
closes #8779

[facebook-github-bot]

Hi @Mrman!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[Mrman]

Now the peerDependency on core-js has been added, can this one go as part of the next milestone @ianschmitz? Think it would warrant a major version bump of babel-preset-react-app.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[Mrman]

PR is not stale, changes to my knowledge are good. Just needs review and release.

Can we get a breaking change and bug fix label added to this PR?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[Mrman]

PR is not stale :)

[Mrman]

Have had to workaround this issue in another project. @ianschmitz / @iansu Is this something can be considered for the 4.1 milestone as a major version release to babel-preset-react-app?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[Mrman]

Resolved conflicts. PR is not stale.

[Semigradsky]

Maybe change version to 3.8? :)

[Mrman]

Maybe change version to 3.8? :)

We can go to 3.6 since that is the latest minor version that react-app-polyfill is pulling in

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[Semigradsky]

As I see react-app-polyfill has "core-js": "^3.19.2", in dependencies, so we can change version to 3.19?

[xprommer]

I need corejs 3.17 for my project,
it would be great to update it to 3.19!