Skip to content

feat(react-scripts): support CSS in JS via Linaria #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jednano
Copy link

@jednano jednano commented May 7, 2019

Fixes #5224

Introduces Linaria as the way to support CSS in JS, because it's the most feature rich option (including TypeScript support).

See this comment for the value proposition.

I got this working in my local dev environment by making these changes directly in my node_modules/react-scripts folder. I followed up with npm run build to see if it worked there too and there were no visible issues. A screenshot would be useless, because it looks exactly the same as a standard CRA home page.

via zero-runtime CSS in JS with Linaria

closes issue facebook#5224
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jun 6, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 6, 2019
@stale
Copy link

stale bot commented Jun 11, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Jun 11, 2019
@jednano
Copy link
Author

jednano commented Jun 11, 2019

For anyone interested, I introduced Linaria without ejecting in this commit.

@lock lock bot locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support scoped CSS in the same file
2 participants