Skip to content

Remove name from splitChunks settings (#4769) #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove name from splitChunks settings (#4769) #4772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ module.exports = {
// https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366
splitChunks: {
chunks: 'all',
name: 'vendors',
},
// Keep the runtime chunk seperated to enable long term caching
// https://twitter.com/wSokra/status/969679223278505985
Expand Down Expand Up @@ -225,7 +224,7 @@ module.exports = {
{
loader: require.resolve('thread-loader'),
options: {
poolTimeout: Infinity // keep workers alive for more effective watch mode
poolTimeout: Infinity, // keep workers alive for more effective watch mode
},
},
{
Expand Down Expand Up @@ -266,7 +265,7 @@ module.exports = {
{
loader: require.resolve('thread-loader'),
options: {
poolTimeout: Infinity // keep workers alive for more effective watch mode
poolTimeout: Infinity, // keep workers alive for more effective watch mode
},
},
{
Expand Down
1 change: 0 additions & 1 deletion packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ module.exports = {
// https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366
splitChunks: {
chunks: 'all',
name: 'vendors',
},
// Keep the runtime chunk seperated to enable long term caching
// https://twitter.com/wSokra/status/969679223278505985
Expand Down