Allow to configure some behaviour for react-scripts start script #3915
Conversation
| clearConsole(); | ||
| } | ||
| console.log(chalk.cyan('Starting the development server...\n')); | ||
| openBrowser(urls.localUrlForBrowser); | ||
| if (!process.env.NO_OPEN_BROWSER) { |
There was a problem hiding this comment.
i think you can set env variable BROWSER=none for this? https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#advanced-configuration
There was a problem hiding this comment.
wow, didn't know that, thanks! 😄
| @@ -106,11 +106,13 @@ checkBrowsers(paths.appPath) | |||
| if (err) { | |||
| return console.log(err); | |||
| } | |||
| if (isInteractive) { | |||
| if (isInteractive && !process.env.NO_CLEAR_CONSOLE) { | |||
There was a problem hiding this comment.
there is a way to achieve the same functionality right now, but not too pretty #2495 (comment)
There was a problem hiding this comment.
watch #3288 for existing PR with the same functionality if you want it using env variable :)
rarguelloF
force-pushed
the
improve-docker-experience
branch
from
3ded3c7 to
562284b
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Closing PR since it's already solved, thanks @viankakrisna ! |
|
happy to help! |
|
Where is this already solved? |
This PR adds 2 new environment variables for configuring some behaviour in the
react-scripts startscript:NO_CLEAR_CONSOLEandNO_OPEN_BROWSER.The motivation behind these changes is to improve the experience executing
create-react-appin environments where there's not a browser installed, like in a docker container.Also, clearing the console might prevent to see the output generated by other containers.