update react error overlay to be compatible with chalk 2 #3843
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| @@ -5,7 +5,8 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
| const webpack = require('webpack'); | |||
| const chalk = require('chalk'); | |||
| const Chalk = require('chalk'); | |||
| const chalk = new Chalk.constructor({ enabled: true, level: 1 }); | |||
There was a problem hiding this comment.
can move this line below the require block ?
There was a problem hiding this comment.
@sendilkumarn yes sure, i'll update it
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
From the screenshot, doesn't look like this helped. |
| @@ -5,11 +5,12 @@ | |||
| * LICENSE file in the root directory of this source tree. | |||
| */ | |||
| const webpack = require('webpack'); | |||
| const chalk = require('chalk'); | |||
| const Chalk = require('chalk'); | |||
There was a problem hiding this comment.
This is the script that builds the error overlay itself. It's not the error overlay.
It is not necessary to change this here, and as you can see on the screenshot, it doesn't fix the problem.
There was a problem hiding this comment.
tnx, i'm working on it...
@gaearon
|
this is fixed in #3849 |
updated react error overlay to be compatible with chalk 2 with @Timer given instructions
