Add env option to babel-preset-react-app

[donocode]

Addresses: #2592

Summary

Adds possibility to specify env/environment option directly to babel-preset-react-app

Examples

"babel": {
    "presets": [
      [ "react-app", { "env": "development" } ]
    ]
  }

"babel": {
    "presets": [
      [ "react-app", { "environment": "production" } ]
    ]
  },

Changes

Code changes are simple, wrap the current preset in a function to allow opts to be specified, plugins are now returned from the function instead of being exported directly

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[react-scripts-dangerous]

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 28eca60) has been released on npm for testing purposes.

npm i [email protected]
# or
yarn add [email protected]
# or
create-react-app [email protected] folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

[gaearon]

Would it be better if this was a breaking change and only respected an explicit option?

[donocode]

Hey @gaearon there isn't a lot of guidance regarding presets but it seems to me like making it an explicit option adds needless complexity. It would also involve changing the way the preset was specified because it could no longer be specified in .babelrc because that would require a static environment. To me it seems like it would be better to respect the BABEL_ENV and NODE_ENV vars while providing an option for the few who need it.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

[stale]

This pull request has been automatically closed because it has not had any recent activity. The conversation will be locked in 7 days unless the pull request is reopened. Thank you for your contribution.