Allow specifying proxySetting via environment variable #11225
Conversation
Allow specifying proxySetting via environment variable as well as by property in package.json
Subterrane
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @Subterrane! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Subterrane
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Subterrane
changed the title
|
Learned that there's another PR for this and found a workaround with patch-package to make the fix myself. |
Allow specifying proxySetting via environment variable as well as by property in package.json
The proxy setting is an all or nothing affair and I have to explain to other devs on my team how to remove the proxy from the package.json file when they try to run in dev mode without a proxy. This is a little tiny change that allows setting a current configuration setting as an environment variable as well as in package.json, so technically I'm not ADDING a configuration. 😄