Skip to content

Allow specifying proxySetting via environment variable #11225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Subterrane
Copy link

Allow specifying proxySetting via environment variable as well as by property in package.json

The proxy setting is an all or nothing affair and I have to explain to other devs on my team how to remove the proxy from the package.json file when they try to run in dev mode without a proxy. This is a little tiny change that allows setting a current configuration setting as an environment variable as well as in package.json, so technically I'm not ADDING a configuration. 😄

Allow specifying proxySetting via environment variable as well as by property in package.json
@facebook-github-bot
Copy link

Hi @Subterrane!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Subterrane Subterrane changed the title Update start.js Allow specifying proxySetting via environment variable as well as by property in package.json Jul 19, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Subterrane Subterrane changed the title Allow specifying proxySetting via environment variable as well as by property in package.json Allow specifying proxySetting via environment variable Jul 19, 2021
@Subterrane
Copy link
Author

Learned that there's another PR for this and found a workaround with patch-package to make the fix myself.

@Subterrane Subterrane closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants