fix: patching formatWebpackMessages #10773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #9880 Message is now an object, and as such this method should be made backwards compatible
chrisarevir
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Was this closed because no one reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #9880
Changes:
Testing strategy
Looking at the main branch, it seems like the failures on this branch are expected for the time being?
Running
yarn e2e:dockeryieldsas an error. If I modify the command to run
e2e-kitchensinkindividually it works, but for the azure pipeline it is failing.