Skip to content

Local contributor end-to-end flow command doesn't use recent packages #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaearon opened this issue Sep 23, 2016 · 1 comment
Closed

Local contributor end-to-end flow command doesn't use recent packages #718

gaearon opened this issue Sep 23, 2016 · 1 comment
Labels
contributions: up for grabs!

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

It seems like localc contributor end-to-end flow command (npm run create-react-app whatever) only uses the master version of react-scripts, but not any of the other packages. We need to fix it to use master versions of all the packages.
@gaearon
Copy link
Contributor Author

gaearon commented Sep 23, 2016

cc @fson who looked into similar issues with e2e test

@fson fson self-assigned this Sep 23, 2016
fson added a commit to fson/create-react-app that referenced this issue Sep 23, 2016
@fson
Use bundled local packages in the end-to-end flow
cafe30e 
Fixes facebook#718.
@fson fson mentioned this issue Sep 23, 2016
Merged
gaearon pushed a commit that referenced this issue Sep 23, 2016
@fson @gaearon
Use bundled local packages in the end-to-end flow (#721)
7c978e5 
Fixes #718.
feiqitian pushed a commit to feiqitian/create-react-app that referenced this issue Oct 25, 2016
@fson @feiqitian
Use bundled local packages in the end-to-end flow (facebook#721)
741b5ae 
Fixes facebook#718.
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
@lock lock bot unassigned fson Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: up for grabs!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fson @gaearon