Skip to content

Conditionally output serve instructions #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evenstensberg opened this issue Jul 8, 2017 · 4 comments
Closed

Conditionally output serve instructions #2750

evenstensberg opened this issue Jul 8, 2017 · 4 comments
Labels
contributions: claimed difficulty: starter issue: proposal

Comments

@evenstensberg
Copy link

Is this a bug report?

No, Enhancement Request

Summary

If you've got serve already installed globally, asking users to install it becomes redundant.

Example:

skjermbilde 2017-07-08 kl 21 08 23

Current Implementation

Current implementation is that the same instruction gets outputted, even though you'd have serve installed after running yarn build

Proposed

  1. Check global prefix and where the users global folder is installed
  2. Print stdout message if it doesn't exist

Use process.argv to map back to where the global folder is, or you could add global-prefix as a dependency.

https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-dev-utils/printHostingInstructions.js#L124-L131

Happy hacking :)
@gaearon gaearon changed the title Good First Contribution: Conditionally output serve instructions Conditionally output serve instructions Jul 8, 2017
@gaearon
Copy link
Contributor

gaearon commented Jul 8, 2017

I renamed because we have labels. Thanks for filing!

@OwenFlood
Copy link
Contributor

I'd love to submit a PR for this, do you think that the redundancy is just the line for installing serve? Or is it the whole section mentioning serve?

@OwenFlood OwenFlood mentioned this issue Jul 10, 2017
Merged
@gaearon
Copy link
Contributor

gaearon commented Jul 10, 2017

Will be fixed by #2761.

@evenstensberg
Copy link
Author

Nice @OwenFlood ! 🔥

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: starter issue: proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaearon @evenstensberg @OwenFlood