WIP

Author: ianschmitz

packages/react-scripts/config/paths.js

@@ -126,33 +126,30 @@ const reactScriptsLinked =
   fs.lstatSync(reactScriptsPath).isSymbolicLink();
 
 // config before publish: we're in ./packages/react-scripts/config/
-
 if (
   !reactScriptsLinked &&
   __dirname.indexOf(path.join('packages', 'react-scripts', 'config')) !== -1
 ) {
-  const template = 'template';
-
   module.exports = {
-    dotenv: resolveOwn(`${template}/.env`),
+    dotenv: resolveOwn('template/.env'),
     appPath: resolveApp('.'),
     appBuild: resolveOwn('../../build'),
-    appPublic: resolveOwn(`${template}/public`),
-    appHtml: resolveOwn(`${template}/public/index.html`),
-    appIndexJs: resolveModule(resolveOwn, `${template}/src/index`),
+    appPublic: resolveOwn('template/public'),
+    appHtml: resolveOwn('template/public/index.html'),
+    appIndexJs: resolveModule(resolveOwn, 'template/src/index'),
     appPackageJson: resolveOwn('package.json'),
-    appSrc: resolveOwn(`${template}/src`),
-    appTsConfig: resolveOwn(`${template}/tsconfig.json`),
-    yarnLockFile: resolveOwn(`${template}/yarn.lock`),
-    testsSetup: resolveModule(resolveOwn, `${template}/src/setupTests`),
-    proxySetup: resolveOwn(`${template}/src/setupProxy.js`),
+    appSrc: resolveOwn('template/src'),
+    appTsConfig: resolveOwn('template/tsconfig.json'),
+    yarnLockFile: resolveOwn('template/yarn.lock'),
+    testsSetup: resolveModule(resolveOwn, 'template/src/setupTests'),
+    proxySetup: resolveOwn('template/src/setupProxy.js'),
     appNodeModules: resolveOwn('node_modules'),
     publicUrl: getPublicUrl(resolveOwn('package.json')),
     servedPath: getServedPath(resolveOwn('package.json')),
     // These properties only exist before ejecting:
     ownPath: resolveOwn('.'),
     ownNodeModules: resolveOwn('node_modules'),
-    appTypeDeclarations: resolveOwn(`${template}/src/react-app-env.d.ts`),
+    appTypeDeclarations: resolveOwn('template/src/react-app-env.d.ts'),
     ownTypeDeclarations: resolveOwn('lib/react-app.d.ts'),
   };
 }

packages/react-scripts/config/tslint.json

@@ -14,7 +14,7 @@
     "no-eval": true,
     "no-floating-promises": true,
     "no-for-in-array": true,
-    "no-implicit-dependencies": true,
+    "no-implicit-dependencies": [true, "dev"],
     "no-invalid-template-strings": true,
     "no-invalid-this": true,
     "no-namespace": true,