Skip to content

Commit 70ff91f

Browse files
wonglkdfacebook-github-bot
authored andcommitted
Add missing numa deps for fedora, rocky, arch (#197)
Summary: Fix OSS builds by adding numa deps to build files. Currently some fail on missing `numa.h`. Context: #161 added the dependencies to the centOS, debian, and ubuntu18 build files. The PR was opened in Sep 2022 but only landed in Dec 2022, and so probably missed out on the fedora, rocky and arch build files which were added in-between those dates. Having had those build actions run on PRs would have caught this (currently, they are only scheduled.) Pull Request resolved: #197 Test Plan: Github Actions builds (ideally, #198 would be landed first.) I've checked that those packages exist for the respective repositories but didn't run them myself. Reviewed By: jaesoo-fb Differential Revision: D43587970 Pulled By: jiayuebao fbshipit-source-id: 8c59e48528042350e576a45ffc3bf2520699f5a9
1 parent f7e13a4 commit 70ff91f

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

contrib/prerequisites-arch.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ sudo pacman -S --needed --noconfirm cmake \
1919
boost \
2020
double-conversion \
2121
libdwarf \
22+
numactl \
2223
libsodium

contrib/prerequisites-fedora32.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ sudo dnf -y install bison flex patch bzip2 cmake \
2121
zlib-devel lz4-devel xz-devel bzip2-devel \
2222
jemalloc-devel snappy-devel libsodium-devel libdwarf-devel libaio-devel \
2323
gmock-devel gflags-devel gtest gtest-devel \
24+
numactl-devel \
2425
fmt fmt-devel
2526

2627
# DO NOT INSTALL glog-devel - need to build from source for the glog-*.cmake files

contrib/prerequisites-fedora34.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ sudo dnf -y install bison flex patch bzip2 cmake \
1919
double-conversion double-conversion-devel make g++ \
2020
boost-devel libevent-devel openssl-devel libunwind-devel \
2121
zlib-devel lz4-devel xz-devel bzip2-devel \
22-
jemalloc-devel snappy-devel libsodium-devel libdwarf-devel libaio-devel
22+
jemalloc-devel snappy-devel libsodium-devel libdwarf-devel libaio-devel \
23+
numactl-devel

contrib/prerequisites-rocky9.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ sudo dnf install -y \
3838
jemalloc-devel \
3939
libsodium-devel \
4040
libaio-devel \
41-
binutils-devel
41+
binutils-devel \
42+
numactl-devel
4243

4344

4445
sudo dnf install -y \

0 commit comments

Comments
 (0)