Skip to content

Configure CI workflow to compile AceTime library example #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Configure CI workflow to compile AceTime library example #3

merged 1 commit into from
Dec 24, 2020

Conversation

per1234
Copy link

@per1234 per1234 commented Dec 23, 2020

This change causes the "Compile Examples" CI workflow to compile AceTime library's "HelloDateTime" example sketch for
every board in the job matrix.

@per1234 per1234 changed the title Configure CI worflow to compile AceTime library example Configure CI workflow to compile AceTime library example Dec 23, 2020
This change causes the "Compile Examples" CI workflow to compile AceTime library's "HelloDateTime" example sketch for
every board in the job matrix.
@per1234
Copy link
Author

per1234 commented Dec 23, 2020

One of the library's example sketches will only compile for the ESP8266 and ESP32, so this made it impossible to compile the entire contents of the examples folder. I chose the "HelloDateTime" example as a representative sketch, but I'm happy to add additional examples if you want better coverage of the library.

@facchinm
Copy link
Owner

AceCommon compilation is failing due to namespace confusion on Print class. However, I'm merging and fixing that one in a separate commit.

@facchinm facchinm merged commit 678d57d into facchinm:pgmspace Dec 24, 2020
@per1234 per1234 deleted the pgmspace branch December 24, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants