Skip to content

Rebase namespace_api on master #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

Rebase namespace_api on master #1

wants to merge 40 commits into from

Conversation

facchinm
Copy link
Owner

@facchinm facchinm commented Apr 9, 2020

No description provided.

facchinm and others added 5 commits April 9, 2020 11:45
@facchinm @giulcioffi
[ArduinoAPI] initial porting
d8f6636
@facchinm @giulcioffi
Add proper guards to UART and CDC
e74e383
@facchinm @giulcioffi
UART: adapt to namespaced ArduinoAPI
d6e174d
@facchinm @giulcioffi
SPI: converto to ArduinoAPI
9adee56
@giulcioffi
File update to use ArduinoCore-API
0b85886 
"Arduino.h" and "USBCore.cpp" modified to be used with ArduinoCore-API.
In "Arduino.h", since "api/ArduinoAPI.h" and "api/Common.h" are included, some defines and
some function definitions can be removed.
"USBCore.cpp" does not include anymore the original "USBAPI.h", hence the function isSuspended()
is not proper of USBDevice_ .
File "Stream.cpp" and "WString.cpp" removed.
The adopted api ArduinoCore-API already supports "Stream.cpp" and "String.cpp".
facchinm
facchinm commented Apr 9, 2020
View reviewed changes
Copy link
Owner Author

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect; to clean it even more, I would squash the commit into the first one of the series, so the comment deletion on Arduino.h would transform into a clean deletion and WString/Stream implementations would be wiped all in one with their definitions

cores/arduino/USBCore.cpp
@@ -862,11 +862,6 @@ bool USBDevice_::wakeupHost()
return false;
}

bool USBDevice_::isSuspended()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function should be restored

giulcioffi added 24 commits April 10, 2020 09:49
@giulcioffi
Rename HardwareSerial classes with UART
9954559
@giulcioffi
Remove common functions already implemented in API
7756db3
@giulcioffi
Port USB to API
3ef2b46 
Move CDC and MSC classes to own files.
Fix all u8/u32 entries to stantard types.
@giulcioffi
Port SPI into API
505541e
@giulcioffi
Port Wire into API
26c204d
@giulcioffi
Adapt digital* APIs to new signatures
f847573
@giulcioffi
Add API folder to compile recipe
9c4860b
@giulcioffi
Merge branch 'namespaced_api' of github.com:giulcioffi/ArduinoCore-av…
117e1e9 
…r into namespaced_api
@giulcioffi
Revert "Merge branch 'namespaced_api' of github.com:giulcioffi/Arduin…
a8e69b6 
…oCore-avr into namespaced_api"

This reverts commit 117e1e9, reversing
changes made to 9c4860b.
@giulcioffi
Add workflow for CI
e3998f8
@giulcioffi
Add MFRC522
dcab1c2
@giulcioffi
Add shared examples
a5e1f58
@giulcioffi
Arduino Mega
82bc00a
@giulcioffi
Add libraries for Basic examples
ac7e0a4
@giulcioffi
Different examples for different boards
53f9b29
@giulcioffi
Move out MultiSerial and USB examples
26fbb76
@giulcioffi
4 boards
97e6543
@giulcioffi
Delete SerialPassthrough
6dc6bef
@giulcioffi
Add boards
1a03846
@giulcioffi
Create 2 jobs
fd4a42d
@giulcioffi
3 jobs
85cdd3a
@giulcioffi
Add SerialPassthrough
7edcd69
@giulcioffi
Add boards to main job
6f5a2ea
@giulcioffi
Move Blink out for Arduino robot Control & Motor
2d61432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@facchinm @giulcioffi