call cache().done() and !noErrors in check and non-check conditions

- instead of making a big `if` statement, decided to split out a `buildDone` function
  - to always call at the end of the input phase

- we can also move the `cache().done()` in `emitSkipped` into `buildEnd`, as `buildEnd` gets called when an error occurs as well
  - and this way we properly print for errors as well

- `buildDone` will have more usage in other PRs as well, so I figure it makes sense to split it out now as well

Author: agilgur5

src/index.ts

@@ -66,6 +66,15 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 				noErrors = false;
 	}
 
+	/** to be called at the end of Rollup's build phase, before output generation */
+	const buildDone = (): void =>
+	{
+		if (!watchMode && !noErrors)
+			context.info(yellow("there were errors or warnings."));
+
+		cache().done();
+	}
+
 	const pluginOptions: IOptions = Object.assign({},
 		{
 			check: true,
@@ -208,7 +217,6 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 					typecheckFile(id, snapshot, contextWrapper);
 
 					// since no output was generated, aborting compilation
-					cache().done();
 					if (_.isFunction(this.error))
 						this.error(red(`failed to transpile '${id}'`));
 				}
@@ -260,7 +268,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 		buildEnd(err)
 		{
 			if (!pluginOptions.check || err)
-				return
+				return buildDone();
 
 			// walkTree once on each cycle when in watch mode
 			if (watchMode)
@@ -290,10 +298,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 					typecheckFile(key, snapshot, context);
 			});
 
-			if (!watchMode && !noErrors)
-				context.info(yellow("there were errors or warnings."));
-
-			cache().done();
+			buildDone();
 		},
 
 		generateBundle(this, _output)