wip: fuse _ongenerate functionality into buildEnd, _onwrite into generateBundle

- per ezolenko, the whole generateRound etc stuff was a workaround because the buildEnd hook actually _didn't exist_ before
  - so now that it does, we can use it to simplify some logic
  - no longer need `_ongenerate` as that should be in `buildEnd`, and no longer need `_onwrite` as it is the only thing called in `generateBundle`, so just combine them
  - importantly, `buildEnd` also occurs before output generation, so this ensures that type-checking still occurs even if `bundle.generate()` is not called

- also move the `walkTree` call to above the "missed" type-checking as it needs to come first
  - it does unconditional type-checking once per watch cycle, whereas "missed" only type-checks those that were, well, "missed"
  - so in order to not have duplication, make "missed" come after, when the `checkedFiles` Set has been filled by `walkTree` already

- and for simplification, just return early on error to match the current behavior
  - in the future, may want to print the error and continue type-checking other files
    - so that all type-check errors are reported, not just the first one

NOTE: this is WIP because the `cache.done()` call and the `!noErrors` message are incorrectly blocked behind the `pluginOptions.check` conditional right now
- `cache.done()` needs to be called regardless of check or error or not, i.e. in all scenarios
  - but ideally it should be called after all the type-checking here
- `!noErrors` should be logged regardless of check or not
  - and similarly, after the type-checking

Author: agilgur5

src/index.ts

@@ -1,6 +1,6 @@
 import { relative, dirname, normalize as pathNormalize, resolve } from "path";
 import * as tsTypes from "typescript";
-import { PluginImpl, PluginContext, InputOptions, OutputOptions, TransformResult, SourceMap, Plugin } from "rollup";
+import { PluginImpl, InputOptions, TransformResult, SourceMap, Plugin } from "rollup";
 import { normalizePath as normalize } from "@rollup/pluginutils";
 import * as _ from "lodash";
 import { blue, red, yellow, green } from "colors/safe";
@@ -90,7 +90,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 	}
 	setTypescriptModule(pluginOptions.typescript);
 
-	const self: Plugin & { _ongenerate: () => void, _onwrite: (this: PluginContext, _output: OutputOptions) => void } = {
+	const self: Plugin = {
 
 		name: "rpt2",
 
@@ -257,11 +257,25 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 			return transformResult;
 		},
 
-		buildEnd()
+		buildEnd(err)
 		{
-			if (!pluginOptions.check)
+			if (!pluginOptions.check || err)
 				return
 
+			// walkTree once on each cycle when in watch mode
+			if (watchMode)
+			{
+				cache().walkTree((id) =>
+				{
+					if (!filter(id))
+						return;
+
+					const snapshot = servicesHost.getScriptSnapshot(id);
+					if (snapshot)
+						typecheckFile(id, snapshot, context);
+				});
+			}
+
 			// type-check missed files as well
 			parsedConfig.fileNames.forEach((name) =>
 			{
@@ -275,40 +289,18 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
 				if (snapshot)
 					typecheckFile(key, snapshot, context);
 			});
-		},
-
-		generateBundle(bundleOptions)
-		{
-			self._ongenerate();
-			self._onwrite.call(this, bundleOptions);
-		},
-
-		_ongenerate(): void
-		{
-			context.debug(() => `generating target ${generateRound + 1}`);
-
-			if (pluginOptions.check && watchMode && generateRound === 0)
-			{
-				cache().walkTree((id) =>
-				{
-					if (!filter(id))
-						return;
-
-					const snapshot = servicesHost.getScriptSnapshot(id);
-					if (snapshot)
-						typecheckFile(id, snapshot, context);
-				});
-			}
 
 			if (!watchMode && !noErrors)
 				context.info(yellow("there were errors or warnings."));
 
 			cache().done();
-			generateRound++;
 		},
 
-		_onwrite(this: PluginContext, _output: OutputOptions): void
+		generateBundle(this, _output)
 		{
+			context.debug(() => `generating target ${generateRound + 1}`);
+			generateRound++;
+
 			if (!parsedConfig.options.declaration)
 				return;