Move ServiceArtifactId to common: [ECR-4279] (#1452)

It might be used by some clients (e.g., the Java service launcher)
to parse the SAID.

Author: dmitry-timofeev

exonum-java-binding/CHANGELOG.md

@@ -121,6 +121,8 @@ stable Exonum release. See [release notes][exonum-1.0.0-rc.1] for details.
 - Java 11 is the minimum required version to run Exonum services.
   _Client_ libraries: `exonum-messages` and `exonum-java-binding-common` remain
   Java 8 compatible.
+- ServiceArtifactId and RuntimeId are moved to 
+  `com.exonum.binding.common.runtime` package. (#1452)
 
 ### Removed
 - Classes supporting no longer used tree-like list proof representation.

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/JavaArtifactUtils.java renamed to exonum-java-binding/common/src/main/java/com/exonum/binding/common/runtime/JavaArtifactUtils.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2019 The Exonum Team
+ * Copyright 2020 The Exonum Team
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package com.exonum.binding.core.runtime;
+package com.exonum.binding.common.runtime;
 
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/RuntimeId.java renamed to exonum-java-binding/common/src/main/java/com/exonum/binding/common/runtime/RuntimeId.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2019 The Exonum Team
+ * Copyright 2020 The Exonum Team
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package com.exonum.binding.core.runtime;
+package com.exonum.binding.common.runtime;
 
 /**
  * Represents well-known runtime ids, as assigned by the Exonum core.

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/ServiceArtifactId.java renamed to exonum-java-binding/common/src/main/java/com/exonum/binding/common/runtime/ServiceArtifactId.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2019 The Exonum Team
+ * Copyright 2020 The Exonum Team
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -14,12 +14,11 @@
  * limitations under the License.
  */
 
-package com.exonum.binding.core.runtime;
+package com.exonum.binding.common.runtime;
 
-import static com.exonum.binding.core.runtime.RuntimeId.JAVA;
+import static com.exonum.binding.common.runtime.RuntimeId.JAVA;
 import static com.google.common.base.Preconditions.checkArgument;
 import static java.lang.Integer.parseInt;
-import static org.apache.logging.log4j.util.Strings.isNotBlank;
 
 import com.exonum.messages.core.runtime.Base.ArtifactId;
 import com.google.auto.value.AutoValue;
@@ -94,6 +93,10 @@ public static ServiceArtifactId valueOf(int runtimeId, String name, String versi
     return new AutoValue_ServiceArtifactId(runtimeId, name, version);
   }
 
+  private static boolean isNotBlank(String s) {
+    return !s.trim().isEmpty();
+  }
+
   /**
    * Creates a new service artifact from the given artifact id message.
    */

exonum-java-binding/core/src/test/java/com/exonum/binding/core/runtime/JavaArtifactUtilsTest.java renamed to exonum-java-binding/common/src/test/java/com/exonum/binding/common/runtime/JavaArtifactUtilsTest.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2019 The Exonum Team
+ * Copyright 2020 The Exonum Team
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -14,9 +14,9 @@
  * limitations under the License.
  */
 
-package com.exonum.binding.core.runtime;
+package com.exonum.binding.common.runtime;
 
-import static com.exonum.binding.core.runtime.JavaArtifactUtils.checkNoForbiddenChars;
+import static com.exonum.binding.common.runtime.JavaArtifactUtils.checkNoForbiddenChars;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.Test;

exonum-java-binding/core/src/test/java/com/exonum/binding/core/runtime/ServiceArtifactIdTest.java renamed to exonum-java-binding/common/src/test/java/com/exonum/binding/common/runtime/ServiceArtifactIdTest.java

@@ -1,11 +1,11 @@
 /*
- * Copyright 2019 The Exonum Team
+ * Copyright 2020 The Exonum Team
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package com.exonum.binding.core.runtime;
+package com.exonum.binding.common.runtime;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertThrows;

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/LoadedServiceDefinition.java

@@ -16,6 +16,7 @@
 
 package com.exonum.binding.core.runtime;
 
+import com.exonum.binding.common.runtime.ServiceArtifactId;
 import com.exonum.binding.core.service.ServiceModule;
 import com.google.auto.value.AutoValue;
 import java.util.function.Supplier;

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/Pf4jServiceLoader.java

@@ -16,11 +16,12 @@
 
 package com.exonum.binding.core.runtime;
 
-import static com.exonum.binding.core.runtime.RuntimeId.JAVA;
+import static com.exonum.binding.common.runtime.RuntimeId.JAVA;
 import static com.google.common.base.Preconditions.checkArgument;
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Preconditions.checkState;
 
+import com.exonum.binding.common.runtime.ServiceArtifactId;
 import com.exonum.binding.core.service.ServiceModule;
 import com.google.common.base.MoreObjects;
 import com.google.inject.Inject;

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/ServiceInstanceSpec.java

@@ -17,6 +17,7 @@
 package com.exonum.binding.core.runtime;
 
 import com.exonum.binding.common.message.TransactionMessage;
+import com.exonum.binding.common.runtime.ServiceArtifactId;
 import com.google.auto.value.AutoValue;
 
 /**

exonum-java-binding/core/src/main/java/com/exonum/binding/core/runtime/ServiceLoader.java

@@ -16,6 +16,7 @@
 
 package com.exonum.binding.core.runtime;
 
+import com.exonum.binding.common.runtime.ServiceArtifactId;
 import java.nio.file.Path;
 import java.util.Optional;