Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Fix wrong typing in events.EventEmitter #167

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Fix wrong typing in events.EventEmitter #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d75c61b
usingDomains is defined only in events module
Feb 21, 2020
d2d5d84
EventEmitter.domain is an object actually
Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/current/src/main/scala/io/scalajs/nodejs/events/EventEmitter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ trait IEventEmitter extends js.Object {
// Properties
/////////////////////////////////////////////////////////////////////////////////

var domain: String = js.native

var usingDomains: Boolean = js.native
var domain: Domain = js.native

/////////////////////////////////////////////////////////////////////////////////
// Methods
Expand Down Expand Up @@ -140,6 +138,8 @@ trait IEventEmitter extends js.Object {
@JSImport("events", JSImport.Namespace)
object EventEmitter extends IEventEmitter {

var usingDomains: Boolean = js.native

/**
* By default, a maximum of 10 listeners can be registered for any single event. This limit can be changed
* for individual EventEmitter instances using the emitter.setMaxListeners(n) method. To change the default
Expand All @@ -151,3 +151,6 @@ object EventEmitter extends IEventEmitter {
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
def once(emitter: IEventEmitter, eventName: String): js.Promise[js.Array[js.Any]] = js.native
}

@js.native
trait Domain extends js.Object