Merge pull request #396 from exoego/nodejs16

Node.js 16

Author: exoego

.github/workflows/ci.yaml

@@ -7,7 +7,7 @@ jobs:
       fail-fast: false
       matrix:
         scala: [2.13.5, 2.12.13]
-        nodejs: [14.16.0, 12.21.0, 10.24.0]
+        nodejs: [16.3.0, 14.16.0, 12.21.0, 10.24.0]
     steps:
       - uses: actions/[email protected]
       - uses: olafurpg/setup-scala@v13

.node-version

@@ -1 +1 @@
-v14.10.0
+v16.3.0

.scalafmt.conf

@@ -1,4 +1,4 @@
-version = "2.7.5"
+version = "3.0.3"
 style = defaultWithAlign
 maxColumn = 120
 align.openParenDefnSite = true

app/nodejs-v10/src/test/scala/io/scalajs/nodejs/TestEnvironment.scala

@@ -9,11 +9,12 @@ object TestEnvironment {
 
   def isWindows: Boolean = os.OS.platform().startsWith("win")
 
+  def isExecutedInExactNode16: Boolean = nodeMajorVersion == 16
   def isExecutedInExactNode14: Boolean = nodeMajorVersion == 14
   def isExecutedInExactNode12: Boolean = nodeMajorVersion == 12
   def isExecutedInExactNode10: Boolean = nodeMajorVersion == 10
-  def isExecutedInExactNode8: Boolean  = nodeMajorVersion == 8
 
+  def isExecutedInNode16OrNewer: Boolean = nodeMajorVersion >= 16
   def isExecutedInNode14OrNewer: Boolean = nodeMajorVersion >= 14
   def isExecutedInNode12OrNewer: Boolean = nodeMajorVersion >= 12
   def isExecutedInNode10OrNewer: Boolean = nodeMajorVersion >= 10

app/nodejs-v10/src/test/scala/io/scalajs/nodejs/buffer/BufferTest.scala

@@ -107,11 +107,7 @@ class BufferTest extends AnyFunSpec {
 
       it("should support isEncoding") {
         assert(!Buffer.isEncoding(null))
-        if (TestEnvironment.isExecutedInExactNode8) {
-          assert(Buffer.isEncoding(""))
-        } else {
-          assert(!Buffer.isEncoding(""))
-        }
+        assert(!Buffer.isEncoding(""))
         assert(Buffer.isEncoding("utf8"))
         assert(Buffer.isEncoding("UTF-8"))
       }

app/nodejs-v10/src/test/scala/io/scalajs/nodejs/perf_hooks/PerformanceObserverTest.scala

@@ -7,10 +7,10 @@ import org.scalatest.funspec.AnyFunSpec
 class ProcessTest extends AnyFunSpec {
   describe("Process") {
     val versionPrefix =
-      if (TestEnvironment.isExecutedInExactNode8) "v8."
-      else if (TestEnvironment.isExecutedInExactNode10) "v10."
+      if (TestEnvironment.isExecutedInExactNode10) "v10."
       else if (TestEnvironment.isExecutedInExactNode12) "v12."
       else if (TestEnvironment.isExecutedInExactNode14) "v14."
+      else if (TestEnvironment.isExecutedInExactNode16) "v16."
       else "Unknown node.js version"
 
     it("contains the following properties") {