Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit e1e6d6e

Browse files
authored
Merge pull request #417 from Jaystified/zlib-fix-wrong-sync-return-types
Fix return types in Zlib facade Sync functions
2 parents db99aa0 + dbe55c6 commit e1e6d6e

File tree

1 file changed

+20
-19
lines changed
  • app/nodejs-v14/src/main/scala/io/scalajs/nodejs/zlib

1 file changed

+20
-19
lines changed

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/zlib/Zlib.scala

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.scalajs.nodejs.zlib
22

33
import com.thoughtworks.enableIf
4+
import io.scalajs.nodejs.buffer.Buffer
45

56
import scala.scalajs.js
67
import scala.scalajs.js.annotation.JSImport
@@ -75,8 +76,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
7576

7677
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliCompressSync(buffer: Data,
7778
options: BrotliOptions
78-
): Unit = js.native
79-
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliCompressSync(buffer: Data): Unit =
79+
): Buffer = js.native
80+
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliCompressSync(buffer: Data): Buffer =
8081
js.native
8182

8283
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
@@ -86,8 +87,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
8687

8788
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliDecompressSync(buffer: Data,
8889
options: BrotliOptions
89-
): Unit = js.native
90-
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliDecompressSync(buffer: Data): Unit =
90+
): Buffer = js.native
91+
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12) def brotliDecompressSync(buffer: Data): Buffer =
9192
js.native
9293

9394
/** Compress a Buffer or string with Deflate.
@@ -99,17 +100,17 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
99100
/** Compress a Buffer or string with Deflate.
100101
* @example zlib.deflateSync(buf[, options])
101102
*/
102-
def deflateSync(buffer: Data, options: CompressionOptions): Unit = js.native
103-
def deflateSync(buffer: Data): Unit = js.native
103+
def deflateSync(buffer: Data, options: CompressionOptions): Buffer = js.native
104+
def deflateSync(buffer: Data): Buffer = js.native
104105

105106
/** Compress a Buffer or string with DeflateRaw.
106107
* @example zlib.deflateRaw(buf[, options], callback)
107108
*/
108109
def deflateRaw(buffer: Data, options: CompressionOptions, callback: js.Function): Unit =
109110
js.native
110-
def deflateRaw(buffer: Data, callback: js.Function): Unit = js.native
111-
def deflateRawSync(buffer: Data, options: CompressionOptions): Unit = js.native
112-
def deflateRawSync(buffer: Data): Unit = js.native
111+
def deflateRaw(buffer: Data, callback: js.Function): Unit = js.native
112+
def deflateRawSync(buffer: Data, options: CompressionOptions): Buffer = js.native
113+
def deflateRawSync(buffer: Data): Buffer = js.native
113114

114115
/** Decompress a Buffer or string with Gunzip.
115116
* @example zlib.gunzip(buf[, options], callback)
@@ -120,8 +121,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
120121
/** Decompress a Buffer or string with Gunzip.
121122
* @example zlib.gunzipSync(buf[, options])
122123
*/
123-
def gunzipSync(buffer: Data, options: CompressionOptions): Unit = js.native
124-
def gunzipSync(buffer: Data): Unit = js.native
124+
def gunzipSync(buffer: Data, options: CompressionOptions): Buffer = js.native
125+
def gunzipSync(buffer: Data): Buffer = js.native
125126

126127
/** Compress a Buffer or string with Gzip.
127128
* @example zlib.gzip(buf[, options], callback)
@@ -132,8 +133,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
132133
/** Compress a Buffer or string with Gzip.
133134
* @example zlib.gzipSync(buf[, options])
134135
*/
135-
def gzipSync(buffer: Data, options: CompressionOptions): Unit = js.native
136-
def gzipSync(buffer: Data): Unit = js.native
136+
def gzipSync(buffer: Data, options: CompressionOptions): Buffer = js.native
137+
def gzipSync(buffer: Data): Buffer = js.native
137138

138139
/** Decompress a Buffer or string with Inflate.
139140
* @example zlib.inflate(buf[, options], callback)
@@ -144,8 +145,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
144145
/** Decompress a Buffer or string with Inflate.
145146
* @example zlib.inflateSync(buf[, options])
146147
*/
147-
def inflateSync(buffer: Data, options: CompressionOptions): Unit = js.native
148-
def inflateSync(buffer: Data): Unit = js.native
148+
def inflateSync(buffer: Data, options: CompressionOptions): Buffer = js.native
149+
def inflateSync(buffer: Data): Buffer = js.native
149150

150151
/** Decompress a Buffer or string with InflateRaw.
151152
* @example zlib.inflateRaw(buf[, options], callback)
@@ -157,8 +158,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
157158
/** Decompress a Buffer or string with InflateRaw.
158159
* @example zlib.inflateRawSync(buf[, options])
159160
*/
160-
def inflateRawSync(buffer: Data, options: CompressionOptions): Unit = js.native
161-
def inflateRawSync(buffer: Data): Unit = js.native
161+
def inflateRawSync(buffer: Data, options: CompressionOptions): Buffer = js.native
162+
def inflateRawSync(buffer: Data): Buffer = js.native
162163

163164
/** Decompress a Buffer or string with Unzip.
164165
* @example zlib.unzip(buf[, options], callback)
@@ -169,8 +170,8 @@ trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
169170
/** Decompress a Buffer or string with Unzip.
170171
* @example zlib.unzipSync(buf[, options])
171172
*/
172-
def unzipSync(buffer: Data, options: CompressionOptions): Unit = js.native
173-
def unzipSync(buffer: Data): Unit = js.native
173+
def unzipSync(buffer: Data, options: CompressionOptions): Buffer = js.native
174+
def unzipSync(buffer: Data): Buffer = js.native
174175
}
175176

176177
/** Zlib Singleton

0 commit comments

Comments
 (0)