Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 6d9dc88

Browse files
authored
Merge pull request #248 from exoego/fix-jsimport
[fs] WriteStream wrongly imports ReadStream
2 parents 166a017 + 315455c commit 6d9dc88

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/nodejs-v10/src/test/scala/io/scalajs/nodejs/fs/FsClassesTest.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ class FsClassesTest extends AnyFunSpec {
1010

1111
describe("ReadStream") {
1212
it("supports constructor(") {
13-
assert(new ReadStream("package.json") !== null)
13+
assert(new ReadStream("package.json").readableLength === 0)
1414
assert(new ReadStream(Buffer.from("package.json")) !== null)
1515
assert(new ReadStream(new URL(s"file:///${dirname}/package.json")) !== null)
1616
}
1717
}
1818

1919
describe("WriteStream") {
2020
it("supports constructor") {
21-
assert(new WriteStream("package.json") !== null)
22-
assert(new WriteStream(Buffer.from("package.json")) !== null)
23-
assert(new WriteStream(new URL(s"file:///${dirname}/package.json")) !== null)
21+
assert(new WriteStream("NO_SUCH_FILE").writableLength === 0)
22+
assert(new WriteStream(Buffer.from("NO_SUCH_FILE")) !== null)
23+
assert(new WriteStream(new URL(s"file:///${dirname}/NO_SUCH_FILE")) !== null)
2424
}
2525
}
2626
}

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/fs/WriteStream.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import scala.scalajs.js.|
1212
* @see https://nodejs.org/api/fs.html#fs_class_fs_writestream
1313
*/
1414
@js.native
15-
@JSImport("fs", "ReadStream")
15+
@JSImport("fs", "WriteStream")
1616
class WriteStream(path: Path) extends stream.Writable {
1717
/////////////////////////////////////////////////////////////////////////////////
1818
// Properties

0 commit comments

Comments
 (0)