Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 166a017

Browse files
authored
Merge pull request #249 from exoego/readableFlowing-null
[stream] Readable.redableFlowing should be nullary
2 parents 383df29 + 4b1bde3 commit 166a017

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

app/nodejs-v12/src/test/scala/io/scalajs/nodejs/stream/ReadableTest.scala

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,12 @@ class ReadableTest extends AnyFunSpec {
88
it("readableEncoding") {
99
assert(new ReadStream("package.json").readableEncoding === null)
1010
}
11+
12+
it("readableFlowing") {
13+
val rs = new ReadStream("package.json")
14+
assert(rs.readableFlowing === null)
15+
rs.on("readable", () => {})
16+
assert(rs.readableFlowing === false)
17+
}
1118
}
1219
}

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/stream/Stream.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ sealed trait IReadable extends LegacyStream {
159159
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
160160
def readableEnded: Boolean = js.native
161161

162-
def readableFlowing: Boolean = js.native
162+
def readableFlowing: Boolean | Null = js.native
163163

164164
def readableHighWaterMark: Double = js.native
165165

0 commit comments

Comments
 (0)