Merge pull request #273 from exoego/constructor-cleanup

[refactoring] Constructor cleanup

Author: exoego

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/Error.scala

@@ -15,8 +15,8 @@ import scala.scalajs.js.annotation.JSGlobal
   */
 @js.native
 @JSGlobal
-class Error(message0: String) extends js.Object {
-  def this() = this(???)
+class Error() extends js.Object {
+  def this(message0: String) = this()
 
   /**
     * The `error.code` property is a string label that identifies the kind of error.

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/StringDecoder.scala

@@ -13,8 +13,8 @@ import scala.scalajs.js.|
   */
 @js.native
 @JSImport("string_decoder", "StringDecoder")
-class StringDecoder(encoding: String) extends IEventEmitter {
-  def this() = this(???)
+class StringDecoder() extends IEventEmitter {
+  def this(encoding: String) = this()
 
   /**
     * Returns any trailing bytes that were left in the buffer.

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/buffer/Buffer.scala

@@ -12,7 +12,7 @@ import scala.scalajs.js.|
   */
 @js.native
 @JSImport("buffer", "Buffer")
-class Buffer private[this] () extends Uint8Array( /* dummy to trick constructor */ -1) {
+class Buffer protected () extends Uint8Array( /* dummy to trick constructor */ -1) {
 
   /**
     * The index operator `[index]` can be used to get and set the octet at position `index` in `buf`.

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/dgram/Socket.scala

@@ -17,7 +17,7 @@ import scala.scalajs.js.annotation.JSImport
   */
 @js.native
 @JSImport("dgram", "Socket")
-class Socket private[this] () extends IEventEmitter {
+class Socket protected () extends IEventEmitter {
 
   /**
     * Tells the kernel to join a multicast group at the given multicastAddress and multicastInterface using the

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/http/Agent.scala

@@ -15,8 +15,8 @@ import scala.scalajs.js.annotation.JSImport
   */
 @js.native
 @JSImport("http", "Agent")
-class Agent(options: AgentOptions) extends IEventEmitter {
-  def this() = this(???)
+class Agent() extends IEventEmitter {
+  def this(options: AgentOptions) = this()
 
   /////////////////////////////////////////////////////////////////////////////////
   //      Properties

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/https/Agent.scala

@@ -10,6 +10,6 @@ import scala.scalajs.js.annotation.JSImport
   */
 @js.native
 @JSImport("https", "Agent")
-class Agent(options: AgentOptions) extends nodejs.http.Agent {
-  def this() = this(???)
+class Agent() extends nodejs.http.Agent {
+  def this(options: AgentOptions) = this()
 }

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/net/Server.scala

@@ -13,10 +13,10 @@ import scala.scalajs.js.|
   */
 @js.native
 @JSImport("net", "Server")
-class Server(options: ServerOptions, connectionListener: js.Function) extends IEventEmitter {
-  def this() = this(???, ???)
-  def this(options: ServerOptions) = this(???, ???)
-  def this(connectionListener: js.Function) = this(???, ???)
+class Server() extends IEventEmitter {
+  def this(options: ServerOptions, connectionListener: js.Function) = this()
+  def this(options: ServerOptions) = this()
+  def this(connectionListener: js.Function) = this()
 
   /**
     * A Boolean indicating whether or not the server is listening for connections.

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/net/Socket.scala

@@ -13,8 +13,8 @@ import scala.scalajs.js.annotation.JSImport
   */
 @js.native
 @JSImport("net", "Socket")
-class Socket(options: SocketOptions) extends stream.Duplex with HasHandle {
-  def this() = this(???)
+class Socket() extends stream.Duplex with HasHandle {
+  def this(options: SocketOptions) = this()
 
   /**
     * net.Socket has the property that socket.write() always works. This is to help users get up and running quickly.

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/net/package.scala

@@ -108,7 +108,7 @@ package object net {
       *
       * See also: the return values of socket.write()
       * @param callback the callback
-      * @example socket.on("drain", function(???) { ... })
+      * @example socket.on("drain", function() { ... })
       */
     @inline def onDrain(callback: () => Any): T = socket.on("drain", callback)
 
@@ -120,7 +120,7 @@ package object net {
       * side allowing the user to write arbitrary amounts of data, with the caveat that the user is required to end()
       * their side now.
       * @param callback the callback
-      * @example socket.on("end", function(???) { ... })
+      * @example socket.on("end", function() { ... })
       */
     @inline def onEnd(callback: () => Any): T = socket.on("end", callback)
 
@@ -147,7 +147,7 @@ package object net {
       *
       * See also: socket.setTimeout()
       * @param callback the callback
-      * @example socket.on("timeout", function(???) { ... })
+      * @example socket.on("timeout", function() { ... })
       */
     @inline def onTimeout(callback: js.Function): T = socket.on("timeout", callback)
   }

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/stream/Stream.scala

@@ -50,8 +50,8 @@ object Stream extends js.Object {
   */
 @js.native
 @JSImport("stream", "Readable")
-class Readable(options: ReadableOptions) extends IReadable {
-  def this() = this(???)
+class Readable() extends IReadable {
+  def this(options: ReadableOptions) = this()
 }
 
 @js.native
@@ -71,8 +71,8 @@ object Readable extends js.Object {
   */
 @js.native
 @JSImport("stream", "Writable")
-class Writable(options: WritableOptions) extends IWritable {
-  def this() = this(???)
+class Writable() extends IWritable {
+  def this(options: WritableOptions) = this()
 }
 
 /**
@@ -88,8 +88,8 @@ class Writable(options: WritableOptions) extends IWritable {
   */
 @js.native
 @JSImport("stream", "Duplex")
-class Duplex(options: DuplexOptions) extends IDuplex {
-  def this() = this(???)
+class Duplex() extends IDuplex {
+  def this(options: DuplexOptions) = this()
 }
 
 /**
@@ -98,8 +98,8 @@ class Duplex(options: DuplexOptions) extends IDuplex {
   */
 @js.native
 @JSImport("stream", "Transform")
-class Transform(options: TransformOptions) extends ITransform {
-  def this() = this(???)
+class Transform() extends ITransform {
+  def this(options: TransformOptions) = this()
 }
 
 /**

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/tls/TLSSocket.scala

@@ -14,13 +14,12 @@ import scala.scalajs.js.|
   * and all required TLS negotiation.
   *
   * Instances of tls.TLSSocket implement the duplex Stream interface.
-  * @param socket  An instance of [[net.Socket]]
-  * @param options the optional settings
   */
 @js.native
 @JSImport("tls", "TLSSocket")
-class TLSSocket(socket: stream.IDuplex, options: TLSSocketOptions) extends net.Socket {
-  def this(socket: stream.IDuplex) = this(???, ???)
+class TLSSocket protected () extends net.Socket {
+  def this(socket: stream.IDuplex, options: TLSSocketOptions) = this()
+  def this(socket: stream.IDuplex) = this()
 
   def authorizationError: js.UndefOr[Boolean] = js.native
 

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/vm/Script.scala

@@ -12,7 +12,7 @@ import scala.scalajs.js.|
   */
 @js.native
 @JSImport("vm", "Script")
-class Script private[this] () extends js.Object {
+class Script protected () extends js.Object {
   def this(code: String, options: ScriptOptions) = this()
   def this(code: String, filename: String) = this()
   def this(code: String) = this()

app/nodejs-v14/src/main/scala/io/scalajs/nodejs/worker_threads/Worker.scala

@@ -8,8 +8,9 @@ import scala.scalajs.js.annotation.JSImport
 
 @js.native
 @JSImport("worker_threads", "Worker")
-class Worker(filename: String, workerOptions: WorkerOptions) extends js.Object with MessagePoster {
-  def this(filename: String) = this(???, ???)
+class Worker protected () extends js.Object with MessagePoster {
+  def this(filename: String, workerOptions: WorkerOptions) = this()
+  def this(filename: String) = this()
 
   def ref(): Unit   = js.native
   def unref(): Unit = js.native