-
-
Notifications
You must be signed in to change notification settings - Fork 554
Update Diamond #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Diamond #2506
Changes from all commits
acfce29
44cea9b
d9173b8
07979f0
2ff06f5
7963932
cba7b16
672f5ad
bc1bac3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,25 +1,10 @@ | ||||||||||
# Description | ||||||||||
|
||||||||||
The diamond kata takes as its input a letter, and outputs it in a diamond shape. | ||||||||||
Given a letter, it prints a diamond starting with 'A', with the supplied letter at the widest point. | ||||||||||
Your goal is to create a diamond shape using letters and spaces. | ||||||||||
|
||||||||||
## Requirements | ||||||||||
You're given a letter, which represents the widest point of the diamond. | ||||||||||
|
||||||||||
- The first row contains one 'A'. | ||||||||||
- The last row contains one 'A'. | ||||||||||
- All rows, except the first and last, have exactly two identical letters. | ||||||||||
- All rows have as many trailing spaces as leading spaces. (This might be 0). | ||||||||||
- The diamond is horizontally symmetric. | ||||||||||
- The diamond is vertically symmetric. | ||||||||||
- The diamond has a square shape (width equals height). | ||||||||||
- The letters form a diamond shape. | ||||||||||
- The top half has the letters in ascending order. | ||||||||||
- The bottom half has the letters in descending order. | ||||||||||
- The four corners (containing the spaces) are triangles. | ||||||||||
|
||||||||||
## Examples | ||||||||||
|
||||||||||
In the following examples, spaces are indicated by `·` characters. | ||||||||||
Let's look at some examples. | ||||||||||
|
||||||||||
Diamond for letter 'A': | ||||||||||
|
||||||||||
|
@@ -30,23 +15,37 @@ A | |||||||||
Diamond for letter 'C': | ||||||||||
|
||||||||||
```text | ||||||||||
··A·· | ||||||||||
·B·B· | ||||||||||
C···C | ||||||||||
·B·B· | ||||||||||
··A·· | ||||||||||
A | ||||||||||
B B | ||||||||||
C C | ||||||||||
B B | ||||||||||
A | ||||||||||
``` | ||||||||||
|
||||||||||
Diamond for letter 'E': | ||||||||||
|
||||||||||
```text | ||||||||||
····A···· | ||||||||||
···B·B··· | ||||||||||
··C···C·· | ||||||||||
·D·····D· | ||||||||||
E·······E | ||||||||||
·D·····D· | ||||||||||
··C···C·· | ||||||||||
···B·B··· | ||||||||||
····A···· | ||||||||||
A | ||||||||||
B B | ||||||||||
C C | ||||||||||
D D | ||||||||||
E E | ||||||||||
D D | ||||||||||
C C | ||||||||||
B B | ||||||||||
A | ||||||||||
``` | ||||||||||
|
||||||||||
## These are the full requirements | ||||||||||
|
||||||||||
- The diamond has a square shape (width equals height). | ||||||||||
- The letters form a diamond shape. | ||||||||||
Comment on lines
+41
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The letters form a diamond shape, and the diamond has a square shape? This is unclear. The square shape refers to what? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see where my confusion came from. The diamond is introduced before explaining what it refers to. Might be better to simply reverse the order of the first two requirements Edit: Removing the unneeded repetition of the word 'shape' may also be preferable since the requirements seem to suggest that we have both a diamond shape and a square shape
Suggested change
|
||||||||||
- The top half has the letters in ascending order. | ||||||||||
- The bottom half has the letters in descending order. | ||||||||||
- All rows, except the first and last, have exactly two identical letters. | ||||||||||
- The first row contains one 'A'. | ||||||||||
- The last row contains one 'A'. | ||||||||||
- All rows have as many trailing spaces as leading spaces (this might be 0 spaces). | ||||||||||
- The diamond is horizontally symmetric. | ||||||||||
- The diamond is vertically symmetric. | ||||||||||
- The four corners (containing the spaces) are triangles. | ||||||||||
iHiD marked this conversation as resolved.
Show resolved
Hide resolved
|
Uh oh!
There was an error while loading. Please reload this page.