Replace regexes with pairvalues in atbash-cipher (#323)

Daniel Mita · web-flow · commit 91627ac55811 · 2019-10-01T00:26:14.000+01:00
diff --git a/exercises/atbash-cipher/.meta/exercise-data.yaml b/exercises/atbash-cipher/.meta/exercise-data.yaml
@@ -13,11 +13,13 @@ tests: |-
   }
 
 example: |-
+  use List::Util qw(pairvalues);
+
   my %dict;
   @dict{'a'..'z'} = reverse('a'..'z');
 
   sub encode_atbash {
-    join( ' ', split( /(\w{5})/, decode_atbash(@_) ) ) =~ s/\s+/ /gr =~ s/^\s//r;
+    join( ' ', pairvalues split( /(\w{1,5})/, decode_atbash(@_) ) );
   }
 
   sub decode_atbash {
diff --git a/exercises/atbash-cipher/.meta/solutions/AtbashCipher.pm b/exercises/atbash-cipher/.meta/solutions/AtbashCipher.pm
@@ -4,12 +4,13 @@ use warnings;
 use Exporter 'import';
 our @EXPORT_OK = qw(encode_atbash decode_atbash);
 
+use List::Util qw(pairvalues);
+
 my %dict;
 @dict{ 'a' .. 'z' } = reverse( 'a' .. 'z' );
 
 sub encode_atbash {
-  join( ' ', split( /(\w{5})/, decode_atbash(@_) ) ) =~ s/\s+/ /gr
-    =~ s/^\s//r;
+  join( ' ', pairvalues split( /(\w{1,5})/, decode_atbash(@_) ) );
 }
 
 sub decode_atbash {

Original file line number	Diff line number	Diff line change
`@@ -13,11 +13,13 @@ tests: \|-`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`example: \|-`
	`16`	`+ use List::Util qw(pairvalues);`
	`17`	`+`
`16`	`18`	`my %dict;`
`17`	`19`	`@dict{'a'..'z'} = reverse('a'..'z');`
`18`	`20`
`19`	`21`	`sub encode_atbash {`
`20`		`- join( ' ', split( /(\w{5})/, decode_atbash(@_) ) ) =~ s/\s+/ /gr =~ s/^\s//r;`
	`22`	`+ join( ' ', pairvalues split( /(\w{1,5})/, decode_atbash(@_) ) );`
`21`	`23`	`}`
`22`	`24`
`23`	`25`	`sub decode_atbash {`