Skip to content

Commit a387c3f

Browse files
Merge branch 'main' into bird-watcher
2 parents d3ed75b + 48e725c commit a387c3f

File tree

439 files changed

+3373
-1833
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

439 files changed

+3373
-1833
lines changed

.appends/.github/labels.yml

Lines changed: 13 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,6 @@
33
# https://github.com/exercism/org-wide-files/blob/main/global-files/.github/labels.yml. #
44
# ----------------------------------------------------------------------------------------- #
55

6-
- name: "README/discrepancy"
7-
description: ""
8-
color: "d93f0b"
9-
10-
- name: "README/inadequate"
11-
description: ""
12-
color: "d93f0b"
13-
146
- name: "action/stale"
157
description: "Applied (and removed) automatically by the stale workflow to indicate an issue or pull request is stale"
168
color: "d93f0b"
@@ -23,12 +15,8 @@
2315
description: "This pull request is waiting on the contributor."
2416
color: "4231af"
2517

26-
- name: "status/future"
27-
description: "This pull request needs to be reconsidered at some point in the future."
28-
color: "4231af"
29-
3018
- name: "bug"
31-
description: ""
19+
description: "Marks that something is broken and needs to be fixed."
3220
color: "fc2929"
3321

3422
- name: "dependencies"
@@ -47,18 +35,10 @@
4735
description: ""
4836
color: "7057ff"
4937

50-
- name: "hacktoberfest"
51-
description: ""
52-
color: "cc8744"
53-
5438
- name: "help wanted"
5539
description: ""
5640
color: "5319e7"
5741

58-
- name: "in-progress"
59-
description: ""
60-
color: "9FDB12"
61-
6242
- name: "invalid"
6343
description: ""
6444
color: "e6e6e6"
@@ -72,7 +52,11 @@
7252
color: "0052cc"
7353

7454
- name: "pinned"
75-
description: ""
55+
description: "Shown at the top of the issue page"
56+
color: "fef2c0"
57+
58+
- name: "discussion"
59+
description: "This is a topic for a longer discussion. The issue can stay open for a while."
7660
color: "fef2c0"
7761

7862
- name: "problem-spec"
@@ -83,18 +67,14 @@
8367
description: ""
8468
color: "cc317c"
8569

86-
- name: "test suite"
87-
description: ""
88-
color: "f9d0c4"
89-
90-
- name: "v3"
91-
description: ""
92-
color: "13B0D1"
93-
9470
- name: "wontfix"
9571
description: ""
9672
color: "ffffff"
9773

98-
- name: "september-sprint"
99-
description: "Part of the September sprint to get the Go track in great shape"
100-
color: "0846af"
74+
- name: "abandoned"
75+
description: "The creator of this issue or PR does not respond anymore."
76+
color: "c7c5c5"
77+
78+
- name: "chore"
79+
description: "Some cleanup/house-keeping needs to be done here."
80+
color: "495747"

.github/labels.yml

Lines changed: 40 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -22,116 +22,116 @@
2222
# The `x:action/<value>` labels describe what sort of work the contributor will be engaged in when working on the issue
2323
- name: "x:action/create"
2424
description: "Work on something from scratch"
25-
color: "6f60d2"
25+
color: "ffffff"
2626

2727
- name: "x:action/fix"
2828
description: "Fix an issue"
29-
color: "6f60d2"
29+
color: "ffffff"
3030

3131
- name: "x:action/improve"
3232
description: "Improve existing functionality/content"
33-
color: "6f60d2"
33+
color: "ffffff"
3434

3535
- name: "x:action/proofread"
3636
description: "Proofread text"
37-
color: "6f60d2"
37+
color: "ffffff"
3838

3939
- name: "x:action/sync"
4040
description: "Sync content with its latest version"
41-
color: "6f60d2"
41+
color: "ffffff"
4242

4343
# The `x:knowledge/<value>` labels describe how much Exercism knowledge is required by the contributor
4444
- name: "x:knowledge/none"
4545
description: "No existing Exercism knowledge required"
46-
color: "604fcd"
46+
color: "ffffff"
4747

4848
- name: "x:knowledge/elementary"
4949
description: "Little Exercism knowledge required"
50-
color: "604fcd"
50+
color: "ffffff"
5151

5252
- name: "x:knowledge/intermediate"
5353
description: "Quite a bit of Exercism knowledge required"
54-
color: "604fcd"
54+
color: "ffffff"
5555

5656
- name: "x:knowledge/advanced"
5757
description: "Comprehensive Exercism knowledge required"
58-
color: "604fcd"
58+
color: "ffffff"
5959

6060
# The `x:module/<value>` labels indicate what part of Exercism the contributor will be working on
6161
- name: "x:module/analyzer"
6262
description: "Work on Analyzers"
63-
color: "5240c9"
63+
color: "ffffff"
6464

6565
- name: "x:module/concept"
6666
description: "Work on Concepts"
67-
color: "5240c9"
67+
color: "ffffff"
6868

6969
- name: "x:module/concept-exercise"
7070
description: "Work on Concept Exercises"
71-
color: "5240c9"
71+
color: "ffffff"
7272

7373
- name: "x:module/generator"
7474
description: "Work on Exercise generators"
75-
color: "5240c9"
75+
color: "ffffff"
7676

7777
- name: "x:module/practice-exercise"
7878
description: "Work on Practice Exercises"
79-
color: "5240c9"
79+
color: "ffffff"
8080

8181
- name: "x:module/representer"
8282
description: "Work on Representers"
83-
color: "5240c9"
83+
color: "ffffff"
8484

8585
- name: "x:module/test-runner"
8686
description: "Work on Test Runners"
87-
color: "5240c9"
87+
color: "ffffff"
8888

8989
# The `x:size/<value>` labels describe the expected amount of work for a contributor
9090
- name: "x:size/tiny"
9191
description: "Tiny amount of work"
92-
color: "4836bf"
92+
color: "ffffff"
9393

9494
- name: "x:size/small"
9595
description: "Small amount of work"
96-
color: "4836bf"
96+
color: "ffffff"
9797

9898
- name: "x:size/medium"
9999
description: "Medium amount of work"
100-
color: "4836bf"
100+
color: "ffffff"
101101

102102
- name: "x:size/large"
103103
description: "Large amount of work"
104-
color: "4836bf"
104+
color: "ffffff"
105105

106106
- name: "x:size/massive"
107107
description: "Massive amount of work"
108-
color: "4836bf"
108+
color: "ffffff"
109109

110110
# The `x:status/<value>` label indicates if there is already someone working on the issue
111111
- name: "x:status/claimed"
112112
description: "Someone is working on this issue"
113-
color: "4231af"
113+
color: "ffffff"
114114

115115
# The `x:type/<value>` labels describe what type of work the contributor will be engaged in
116116
- name: "x:type/ci"
117117
description: "Work on Continuous Integration (e.g. GitHub Actions workflows)"
118-
color: "3c2d9f"
118+
color: "ffffff"
119119

120120
- name: "x:type/coding"
121121
description: "Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)"
122-
color: "3c2d9f"
122+
color: "ffffff"
123123

124124
- name: "x:type/content"
125125
description: "Work on content (e.g. exercises, concepts)"
126-
color: "3c2d9f"
126+
color: "ffffff"
127127

128128
- name: "x:type/docker"
129129
description: "Work on Dockerfiles"
130-
color: "3c2d9f"
130+
color: "ffffff"
131131

132132
- name: "x:type/docs"
133133
description: "Work on Documentation"
134-
color: "3c2d9f"
134+
color: "ffffff"
135135

136136
# This label can be added to accept PRs as part of Hacktoberfest
137137
- name: "hacktoberfest-accepted"
@@ -148,14 +148,6 @@
148148
# https://github.com/exercism/org-wide-files/blob/main/global-files/.github/labels.yml. #
149149
# ----------------------------------------------------------------------------------------- #
150150

151-
- name: "README/discrepancy"
152-
description: ""
153-
color: "d93f0b"
154-
155-
- name: "README/inadequate"
156-
description: ""
157-
color: "d93f0b"
158-
159151
- name: "action/stale"
160152
description: "Applied (and removed) automatically by the stale workflow to indicate an issue or pull request is stale"
161153
color: "d93f0b"
@@ -168,12 +160,8 @@
168160
description: "This pull request is waiting on the contributor."
169161
color: "4231af"
170162

171-
- name: "status/future"
172-
description: "This pull request needs to be reconsidered at some point in the future."
173-
color: "4231af"
174-
175163
- name: "bug"
176-
description: ""
164+
description: "Marks that something is broken and needs to be fixed."
177165
color: "fc2929"
178166

179167
- name: "dependencies"
@@ -192,18 +180,10 @@
192180
description: ""
193181
color: "7057ff"
194182

195-
- name: "hacktoberfest"
196-
description: ""
197-
color: "cc8744"
198-
199183
- name: "help wanted"
200184
description: ""
201185
color: "5319e7"
202186

203-
- name: "in-progress"
204-
description: ""
205-
color: "9FDB12"
206-
207187
- name: "invalid"
208188
description: ""
209189
color: "e6e6e6"
@@ -217,7 +197,11 @@
217197
color: "0052cc"
218198

219199
- name: "pinned"
220-
description: ""
200+
description: "Shown at the top of the issue page"
201+
color: "fef2c0"
202+
203+
- name: "discussion"
204+
description: "This is a topic for a longer discussion. The issue can stay open for a while."
221205
color: "fef2c0"
222206

223207
- name: "problem-spec"
@@ -228,18 +212,14 @@
228212
description: ""
229213
color: "cc317c"
230214

231-
- name: "test suite"
232-
description: ""
233-
color: "f9d0c4"
234-
235-
- name: "v3"
236-
description: ""
237-
color: "13B0D1"
238-
239215
- name: "wontfix"
240216
description: ""
241217
color: "ffffff"
242218

243-
- name: "september-sprint"
244-
description: "Part of the September sprint to get the Go track in great shape"
245-
color: "0846af"
219+
- name: "abandoned"
220+
description: "The creator of this issue or PR does not respond anymore."
221+
color: "c7c5c5"
222+
223+
- name: "chore"
224+
description: "Some cleanup/house-keeping needs to be done here."
225+
color: "495747"

.github/pr-commenter.yml

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,68 @@
1+
comment:
2+
on-update: edit
3+
glob-options:
4+
dot: true
5+
6+
header: |
7+
### Dear {{ prAuthor }}
8+
Thank you for contributing to the Go track on Exercism! 💙
9+
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.
10+
11+
footer: |
12+
13+
<sub>Automated comment created by [PR Commenter](https://github.com/exercism/pr-commenter-action) 🤖.</sub>
14+
15+
snippets:
16+
- id: concept-changes
17+
files:
18+
- 'exercises/concept/*/.docs/introduction.md'
19+
- 'concepts/*/introduction.md'
20+
- 'concepts/*/about.md'
21+
body: |
22+
- 📜 The following files usually contain very similar content.
23+
- `concepts/<concept>/about.md`
24+
- `concepts/<concept>/introduction.md`
25+
- `exercises/concept/<exercise>/.docs/introduction.md`
26+
27+
Please check whether the changes you made to one of these also need to be applied to the others.
28+
29+
- id: exemplar-or-stub-changes
30+
files:
31+
- 'exercises/concept/*/.meta/*.go'
32+
- any:
33+
- 'exercises/concept/*/*.go'
34+
- '!exercises/concept/*/*_test.go'
35+
body: |
36+
- 🧦 If you changed the function signature or the function comment in the exemplar file or the sub file (`<exercise>.go`), make sure the change is applied to both files.
37+
38+
- id: problem-spec-related
39+
files:
40+
- 'exercises/practice/*/*_test.go'
41+
- 'exercises/practice/*/.docs/instructions.md'
42+
body: |
43+
- ⬆️ The instructions and test cases for many practice exercises originate in the Exercism-wide [problem-specifications repo](https://github.com/exercism/problem-specifications). If the exercise you changed is listed there in the [exercises folder](https://github.com/exercism/problem-specifications/tree/main/exercises), please consider the following.
44+
- Improvements to the `instructions.md` file should be made in the problem-spec repo so that all tracks can benefit.
45+
You can open a PR there instead.
46+
- If you want to add some language specific information, use the `instructions.append.md` file (see [Practice Exercise Docs](https://exercism.org/docs/building/tracks/practice-exercises)).
47+
- Test cases selected in the `.meta/tests.toml` file need to be implemented in the `<exercise>_test.go` file according to the specification in [`canonical-data.json`](https://github.com/exercism/problem-specifications#test-data-canonical-datajson).
48+
49+
- id: note-for-contributors
50+
files:
51+
- '*'
52+
- '**/*'
53+
body: |
54+
- ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
55+
56+
- 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found `Unicdoe`, use "replace all" in your editor (or command line magic) to fix it consistently.
57+
58+
- id: note-for-maintainers
59+
files:
60+
- '*'
61+
- '**/*'
62+
body: |
63+
### Dear Reviewer/Maintainer
64+
- 📏 Make sure you set the appropriate **`x:size` label** for the PR. (This also works after merging, in case you forgot about it.)
65+
66+
- 🔍 **Don't be too nit-picky.** If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
67+
68+
- 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are **changes missing** from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

0 commit comments

Comments
 (0)