-
-
Notifications
You must be signed in to change notification settings - Fork 93
Update authors/contributors spec #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -301,12 +301,7 @@ If someone is both an author _and_ a contributor, only list that person as an au | |
|
||
```json | ||
{ | ||
"authors": [ | ||
{ | ||
"github_username": "FSharpForever", | ||
"exercism_username": "FSharpForever" | ||
} | ||
], | ||
"authors": ["FSharpForever"], | ||
"files": { | ||
"solution": ["Lasagna.fs"], | ||
"test": ["LasagnaTests.fs"], | ||
|
@@ -318,33 +313,23 @@ If someone is both an author _and_ a contributor, only list that person as an au | |
|
||
#### Full Example | ||
|
||
Assume that the user FSharpForever has written an exercise called `basics` for the F# track. PythonProfessor adapts the exercise for the Python track. Later on, the user PythonPerfection improves the exercise. | ||
Assume that the user `FSharpForever` has written an exercise called `log-levels` for the F# track. `PythonProfessor` adapts the exercise for the Python track. Later on, the user `GladToHelp` improves the exercise. | ||
|
||
```json | ||
{ | ||
"contributors": [ | ||
{ | ||
"github_username": "PythonPerfection", | ||
"exercism_username": "PythonPerfection" | ||
} | ||
], | ||
"authors": [ | ||
{ | ||
"github_username": "PythonProfessor", | ||
"exercism_username": "PythonProfessor" | ||
} | ||
], | ||
"authors": ["PythonProfessor"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we change this second example so it's more visibly different to the first pls? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something like this (pushed change)? |
||
"contributors": ["GladToHelp"], | ||
"files": { | ||
"solution": ["lasagna.py"], | ||
"test": ["lasagna_test.py"], | ||
"solution": ["log_levels.py"], | ||
"test": ["log_levels_test.py"], | ||
"exemplar": [".meta/exemplar.py"], | ||
"editor": ["test_helper.py"] | ||
}, | ||
"forked_from": ["fsharp/basics"], | ||
"forked_from": ["fsharp/log-levels"], | ||
"language_versions": ">=3.7", | ||
"blurb": "Learn the basics of Python by cooking Guido's Gorgeous Lasagna", | ||
"blurb": "Learn how to work with strings by processing log lines.", | ||
"source": "Wikipedia", | ||
"source_url": "https://en.wikipedia.org/wiki/Lasagne" | ||
"source_url": "https://en.wikipedia.org/wiki/Log_file" | ||
} | ||
``` | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring that
contributors
is non-empty is a new requirement in this PR, and it's not obvious that this was intended.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it should not have been. This is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be fixed in https://github.com/exercism/docs/pull/91/files