Skip to content

🐛 FIX: smartquotes punctuation char comparison #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Nov 4, 2020

This bug was found by running mypy with the strict_equality = True setting. I suggest we turn that setting on in #64

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #72 (035c11c) into master (a874755) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          75       75           
  Lines        3740     3740           
=======================================
  Hits         3573     3573           
  Misses        167      167           
Flag Coverage Δ
pytests 95.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
markdown_it/common/utils.py 67.44% <100.00%> (ø)
markdown_it/rules_core/smartquotes.py 98.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a874755...8cc8de3. Read the comment docs.

@chrisjsewell chrisjsewell changed the title Fix punctuation char comparison in smartquotes.py 🐛 FIX: smartquotes punctuation char comparison Nov 12, 2020
@chrisjsewell chrisjsewell merged commit a29c8bd into executablebooks:master Nov 12, 2020
@hukkin hukkin deleted the fix-smartquotes branch November 12, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants