Skip to content
This repository was archived by the owner on Jun 11, 2019. It is now read-only.

Add nginx as dependency #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jan 30, 2014

No description provided.

@alvagante
Copy link
Member

Uhm, given that nginx is optional I'd not add it as a dependency in the modulefile, eventually i'd just comment it, in order to show thta is needed in case of nginx usage.
The same actually should be done with the apache and mysql modules (the latter being even less useful now that most of the people use PuppetDB).
Sadly I havent' found a more decent way to manage "optional" dependncies in the Modulefile, but I would rather keep them limited (and in some cases incomplete) rather than forcing the installaion of modules that maybe a user doesn't use.

@DavidS
Copy link
Contributor Author

DavidS commented Feb 2, 2014

Yeah, it's just super annoying as I'm totally switching over to nginx and geppetto is always complaining since it can't find all the nginx stuff without a module dependency.

I'm fine with carrying a local patch if required.

@alvagante
Copy link
Member

Yes, I would prefer such an approach for the moment.
Since I'd already strip off the monitor/firewall dependencies when I publish on the Forge, I might do the same for other lazy dependencies in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants