Skip to content

Commit 244deee

Browse files
Retrofit assert_type for Aggregate and Callable (#935)
1 parent d72d07c commit 244deee

File tree

2 files changed

+53
-34
lines changed

2 files changed

+53
-34
lines changed

tests/typing/aggregate.py

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from dependency_injector import providers
2+
from typing_extensions import assert_type, Any
23

34

45
class Animal: ...
@@ -8,29 +9,35 @@ class Cat(Animal): ...
89

910

1011
# Test 1: to check Aggregate provider
11-
provider1: providers.Aggregate[str] = providers.Aggregate(
12+
provider1 = providers.Aggregate(
1213
a=providers.Object("str1"),
1314
b=providers.Object("str2"),
1415
)
15-
provider_a_1: providers.Provider[str] = provider1.a
16+
provider_a_1 = provider1.a
1617
provider_b_1: providers.Provider[str] = provider1.b
17-
val1: str = provider1("a")
18+
val1 = provider1("a")
19+
assert_type(provider1, providers.Aggregate[str])
20+
assert_type(provider_a_1, providers.Provider[str])
21+
assert_type(provider_b_1, providers.Provider[str])
22+
assert_type(val1, str)
1823

19-
provider1_set_non_string_keys: providers.Aggregate[str] = providers.Aggregate()
24+
provider1_set_non_string_keys = providers.Aggregate[str]()
2025
provider1_set_non_string_keys.set_providers({Cat: providers.Object("str")})
21-
provider_set_non_string_1: providers.Provider[str] = (
22-
provider1_set_non_string_keys.providers[Cat]
23-
)
26+
provider_set_non_string_1 = provider1_set_non_string_keys.providers[Cat]
27+
assert_type(provider_set_non_string_1, providers.Provider[str])
28+
2429

25-
provider1_new_non_string_keys: providers.Aggregate[str] = providers.Aggregate(
30+
provider1_new_non_string_keys = providers.Aggregate(
2631
{Cat: providers.Object("str")},
2732
)
28-
factory_new_non_string_1: providers.Provider[str] = (
29-
provider1_new_non_string_keys.providers[Cat]
30-
)
33+
factory_new_non_string_1 = provider1_new_non_string_keys.providers[Cat]
34+
assert_type(provider1_new_non_string_keys, providers.Aggregate[str])
35+
assert_type(factory_new_non_string_1, providers.Provider[str])
36+
3137

3238
provider1_no_explicit_typing = providers.Aggregate(a=providers.Object("str"))
33-
provider1_no_explicit_typing_factory: providers.Provider[str] = (
34-
provider1_no_explicit_typing.providers["a"]
35-
)
36-
provider1_no_explicit_typing_object: str = provider1_no_explicit_typing("a")
39+
provider1_no_explicit_typing_factory = provider1_no_explicit_typing.providers["a"]
40+
provider1_no_explicit_typing_object = provider1_no_explicit_typing("a")
41+
42+
assert_type(provider1_no_explicit_typing_factory, providers.Provider[str])
43+
assert_type(provider1_no_explicit_typing_object, str)

tests/typing/callable.py

Lines changed: 31 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
from typing import Any, Callable, Dict, Optional, Tuple, Type
1+
from typing import Any, Callable, Dict, Optional, Tuple
2+
from typing_extensions import assert_type
23

34
from dependency_injector import providers
45

@@ -7,19 +8,20 @@ class Animal: ...
78

89

910
class Cat(Animal):
10-
1111
@classmethod
1212
def create(cls) -> Animal:
1313
return cls()
1414

1515

1616
# Test 1: to check the return type (class)
1717
provider1 = providers.Callable(Cat)
18-
animal1: Animal = provider1(1, 2, 3, b="1", c=2, e=0.0)
18+
cat1 = provider1(1, 2, 3, b="1", c=2, e=0.0)
19+
assert_type(cat1, Cat)
1920

2021
# Test 2: to check the return type (class factory method)
2122
provider2 = providers.Callable(Cat.create)
22-
animal2: Animal = provider2()
23+
animal2 = provider2()
24+
assert_type(animal2, Animal)
2325

2426
# Test 3: to check the .override() method
2527
provider3 = providers.Callable(Animal)
@@ -28,24 +30,32 @@ def create(cls) -> Animal:
2830

2931
# Test 4: to check the .args & .kwargs attributes
3032
provider4 = providers.Callable(Animal)
31-
args4: Tuple[Any] = provider4.args
32-
kwargs4: Dict[str, Any] = provider4.kwargs
33+
args4 = provider4.args
34+
kwargs4 = provider4.kwargs
35+
assert_type(args4, Tuple[Any])
36+
assert_type(kwargs4, Dict[str, Any])
3337

3438
# Test 5: to check the provided instance interface
3539
provider5 = providers.Callable(Animal)
36-
provided5: Animal = provider5.provided()
37-
attr_getter5: providers.AttributeGetter = provider5.provided.attr
38-
item_getter5: providers.ItemGetter = provider5.provided["item"]
39-
method_caller: providers.MethodCaller = provider5.provided.method.call(123, arg=324)
40+
provided_val5 = provider5.provided()
41+
attr_getter5 = provider5.provided.attr
42+
item_getter5 = provider5.provided["item"]
43+
method_caller5 = provider5.provided.method.call(123, arg=324)
44+
assert_type(provided_val5, Any)
45+
assert_type(attr_getter5, providers.AttributeGetter)
46+
assert_type(item_getter5, providers.ItemGetter)
47+
assert_type(method_caller5, providers.MethodCaller)
4048

4149
# Test 6: to check the DelegatedCallable
4250
provider6 = providers.DelegatedCallable(Cat)
43-
animal6: Animal = provider6(1, 2, 3, b="1", c=2, e=0.0)
51+
cat6 = provider6(1, 2, 3, b="1", c=2, e=0.0)
52+
assert_type(cat6, Cat)
4453

4554
# Test 7: to check the AbstractCallable
4655
provider7 = providers.AbstractCallable(Animal)
4756
provider7.override(providers.Callable(Cat))
48-
animal7: Animal = provider7(1, 2, 3, b="1", c=2, e=0.0)
57+
animal7 = provider7(1, 2, 3, b="1", c=2, e=0.0)
58+
assert_type(animal7, Animal)
4959

5060
# Test 8: to check the CallableDelegate __init__
5161
provider8 = providers.CallableDelegate(providers.Callable(lambda: None))
@@ -55,20 +65,22 @@ def create(cls) -> Animal:
5565

5666

5767
async def _async9() -> None:
58-
animal1: Animal = await provider9(1, 2, 3, b="1", c=2, e=0.0) # type: ignore
59-
animal2: Animal = await provider9.async_(1, 2, 3, b="1", c=2, e=0.0)
68+
await provider9(1, 2, 3, b="1", c=2, e=0.0) # type: ignore[misc]
69+
cat9 = await provider9.async_(1, 2, 3, b="1", c=2, e=0.0)
70+
assert_type(cat9, Cat)
6071

6172

6273
# Test 10: to check the .provides
6374
provider10 = providers.Callable(Cat)
64-
provides10: Optional[Callable[..., Cat]] = provider10.provides
65-
assert provides10 is Cat
75+
provides10 = provider10.provides
76+
assert_type(provides10, Optional[Callable[..., Cat]])
6677

6778
# Test 11: to check the .provides for explicit typevar
6879
provider11 = providers.Callable[Animal](Cat)
69-
provides11: Optional[Callable[..., Animal]] = provider11.provides
70-
assert provides11 is Cat
80+
provides11 = provider11.provides
81+
assert_type(provides11, Optional[Callable[..., Animal]])
82+
7183

7284
# Test 12: to check string imports
73-
provider12: providers.Callable[Dict[Any, Any]] = providers.Callable("builtins.dict")
85+
provider12 = providers.Callable("builtins.dict")
7486
provider12.set_provides("builtins.dict")

0 commit comments

Comments
 (0)