Skip to content

Commit 2c6b7b1

Browse files
authored
fix(apache): only set static port if wanted (#610)
1 parent b96e502 commit 2c6b7b1

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -740,8 +740,8 @@ xatu_sentry_params:
740740

741741
# Apache params
742742
# Apache public port to port forward to local machine
743-
# Default to port 40000, only set if apache additional service is activated
744-
apache_port: 40000
743+
# Default to port None, only set if apache additional service is activated
744+
apache_port: null
745745

746746
# Global tolerations that will be passed to all containers (unless overridden by a more specific toleration)
747747
# Only works with Kubernetes

src/apache/apache_launcher.star

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,13 @@ def launch_apache(
7979
bootstrap_info_files_artifact_name = plan.render_templates(
8080
template_and_data_by_rel_dest_filepath, "bootstrap-info"
8181
)
82-
83-
public_ports = {
84-
HTTP_PORT_ID: shared_utils.new_port_spec(apache_port, shared_utils.TCP_PROTOCOL)
85-
}
82+
public_ports = {}
83+
if apache_port != None:
84+
public_ports = {
85+
HTTP_PORT_ID: shared_utils.new_port_spec(
86+
apache_port, shared_utils.TCP_PROTOCOL
87+
)
88+
}
8689

8790
config = get_config(
8891
config_files_artifact_name,

src/package_io/input_parser.star

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ def default_input_args():
668668
"persistent": False,
669669
"mev_type": None,
670670
"xatu_sentry_enabled": False,
671-
"apache_port": 40000,
671+
"apache_port": None,
672672
"global_tolerations": [],
673673
"global_node_selectors": {},
674674
"keymanager_enabled": False,

0 commit comments

Comments
 (0)