ethereum · fselmo · Feb 21, 2024 · Feb 21, 2024 · Feb 21, 2024
diff --git a/docs/toc.rst b/docs/toc.rst
@@ -40,7 +40,6 @@ Table of Contents
     web3.beacon
     web3.pm
     web3.net
-    web3.miner
     web3.geth
     web3.tracing
     web3.utils

diff --git a/docs/web3.main.rst b/docs/web3.main.rst
@@ -363,10 +363,6 @@ Each ``Web3`` instance also exposes these namespaced API modules.
 
     See :doc:`./web3.eth`
 
-.. py:attribute:: Web3.miner
-
-    See :doc:`./web3.miner`
-
 .. py:attribute:: Web3.pm
 
     See :doc:`./web3.pm`

diff --git a/docs/web3.miner.rst b/docs/web3.miner.rst
diff --git a/newsfragments/3236.removal.rst b/newsfragments/3236.removal.rst
@@ -0,0 +1 @@
+Remove deprecated ``geth.miner`` namespace and methods.
diff --git a/tests/core/txpool-module/test_txpool_content.py b/tests/core/txpool-module/test_txpool_content.py
@@ -8,8 +8,6 @@
 def test_txpool_content(web3_empty):
     web3 = web3_empty
 
-    web3.geth.miner.stop()
-
     with Timeout(60) as timeout:
         while web3.eth.hashrate or web3.eth.mining:
             timeout.sleep(random.random())

diff --git a/tests/core/txpool-module/test_txpool_inspect.py b/tests/core/txpool-module/test_txpool_inspect.py
@@ -8,8 +8,6 @@
 def test_txpool_inspect(web3_empty):
     web3 = web3_empty
 
-    web3.geth.miner.stop()
-
     with Timeout(60) as timeout:
         while web3.eth.hashrate or web3.eth.mining:
             timeout.sleep(random.random())

diff --git a/tests/integration/go_ethereum/test_goethereum_ws_v2/conftest.py b/tests/integration/go_ethereum/test_goethereum_ws_v2/conftest.py
@@ -28,7 +28,7 @@ def _geth_command_arguments(ws_port, base_geth_command_arguments, geth_version):
             "--ws.port",
             ws_port,
             "--ws.api",
-            "admin,eth,net,web3,personal,miner",
+            "admin,eth,net,web3,personal",
             "--ws.origins",
             "*",
             "--ipcdisable",

diff --git a/web3/_utils/miner.py b/web3/_utils/miner.py
diff --git a/web3/_utils/module_testing/module_testing_utils.py b/web3/_utils/module_testing/module_testing_utils.py
@@ -1,7 +1,6 @@
 from collections import (
     deque,
 )
-import time
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -60,17 +59,6 @@
 flaky_geth_dev_mining = flaky(max_runs=3)
 
 
-def mine_pending_block(w3: "Web3") -> None:
-    timeout = 10
-
-    w3.geth.miner.start()  # type: ignore
-    start = time.time()
-    while time.time() < start + timeout:
-        if len(w3.eth.get_block("pending")["transactions"]) == 0:
-            break
-    w3.geth.miner.stop()  # type: ignore
-
-
 def assert_contains_log(
     result: Sequence[LogReceipt],
     block_with_txn_with_log: BlockData,

diff --git a/web3/_utils/rpc_abi.py b/web3/_utils/rpc_abi.py
@@ -114,16 +114,6 @@ class RPC:
     evm_revert = RPCEndpoint("evm_revert")
     evm_snapshot = RPCEndpoint("evm_snapshot")
 
-    # miner
-    miner_makeDag = RPCEndpoint("miner_makeDag")
-    miner_setExtra = RPCEndpoint("miner_setExtra")
-    miner_setEtherbase = RPCEndpoint("miner_setEtherbase")
-    miner_setGasPrice = RPCEndpoint("miner_setGasPrice")
-    miner_start = RPCEndpoint("miner_start")
-    miner_stop = RPCEndpoint("miner_stop")
-    miner_startAutoDag = RPCEndpoint("miner_startAutoDag")
-    miner_stopAutoDag = RPCEndpoint("miner_stopAutoDag")
-
     # net
     net_listening = RPCEndpoint("net_listening")
     net_peerCount = RPCEndpoint("net_peerCount")

diff --git a/web3/geth.py b/web3/geth.py
@@ -21,16 +21,6 @@
 from web3._utils.compat import (
     Protocol,
 )
-from web3._utils.miner import (
-    make_dag,
-    set_etherbase,
-    set_extra,
-    set_gas_price,
-    start,
-    start_auto_dag,
-    stop,
-    stop_auto_dag,
-)
 from web3._utils.rpc_abi import (
     RPC,
 )
@@ -215,21 +205,6 @@ class GethAdmin(Module):
     )
 
 
-class GethMiner(Module):
-    """
-    https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-miner
-    """
-
-    make_dag = make_dag
-    set_extra = set_extra
-    set_etherbase = set_etherbase
-    set_gas_price = set_gas_price
-    start = start
-    stop = stop
-    start_auto_dag = start_auto_dag
-    stop_auto_dag = stop_auto_dag
-
-
 class Geth(Module):
     personal: GethPersonal
     admin: GethAdmin

diff --git a/web3/main.py b/web3/main.py
@@ -95,7 +95,6 @@
     AsyncGethTxPool,
     Geth,
     GethAdmin,
-    GethMiner,
     GethPersonal,
     GethTxPool,
 )
@@ -171,7 +170,6 @@ def get_default_modules() -> Dict[str, Union[Type[Module], Sequence[Any]]]:
             Geth,
             {
                 "admin": GethAdmin,
-                "miner": GethMiner,
                 "personal": GethPersonal,
                 "txpool": GethTxPool,
             },

diff --git a/web3/providers/eth_tester/defaults.py b/web3/providers/eth_tester/defaults.py
@@ -404,15 +404,6 @@ def personal_send_transaction(eth_tester: "EthereumTester", params: Any) -> HexS
         "writeBlockProfile": not_implemented,
         "writeMemProfile": not_implemented,
     },
-    "miner": {
-        "make_dag": not_implemented,
-        "set_extra": not_implemented,
-        "set_gas_price": not_implemented,
-        "start": not_implemented,
-        "stop": not_implemented,
-        "start_auto_dag": not_implemented,
-        "stop_auto_dag": not_implemented,
-    },
     "personal": {
         "ec_recover": not_implemented,
         "import_raw_key": call_eth_tester("add_account"),

diff --git a/web3/providers/rpc/utils.py b/web3/providers/rpc/utils.py
@@ -13,7 +13,6 @@
 
 REQUEST_RETRY_ALLOWLIST = [
     "admin",
-    "miner",
     "net",
     "txpool",
     "testing",
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Remove deprecated ``geth.miner`` namespace and methods.